Adding close connection support to HttpClient to combat hanging open files

Added a .close() method to org.openqa.selenium.remote.http.HttpClient
interface.

Added a call to the client's .close() method from the
HttpCommandExecutor class when a
org.openqa.selenium.remote.DriverCommand.QUIT is sent.

Implemented the .close() method in
org.openqa.selenium.remote.internal.ApacheHttpClient which taps the
connectionManager and closes idle connections.

Fixes SeleniumHQ#1080

Signed-off-by: Alexei Barantsev <[email protected]>

Author: cgamache

java/client/src/org/openqa/selenium/remote/HttpCommandExecutor.java

@@ -147,6 +147,9 @@ public Response execute(Command command) throws IOException {
         String sessionId = HttpSessionId.getSessionId(httpResponse.getTargetHost());
         response.setSessionId(sessionId);
       }
+      if (QUIT.equals(command.getName())) {
+    	  client.close();
+      }
       return response;
     } catch (UnsupportedCommandException e) {
       if (e.getMessage() == null || "".equals(e.getMessage())) {

java/client/src/org/openqa/selenium/remote/http/HttpClient.java

@@ -34,10 +34,14 @@ public interface HttpClient {
    * @throws IOException if an I/O error occurs.
    */
   HttpResponse execute(HttpRequest request, boolean followRedirects) throws IOException;
-
+  
   /**
-   * Creates HttpClient instances.
-   */
+	* Closes the connections associated with this client. 
+	*
+	* @throws  IOException  if an I/O error occurs.
+	*/
+  void close() throws IOException;
+
   interface Factory {
 
     /**

java/client/src/org/openqa/selenium/remote/internal/ApacheHttpClient.java

@@ -48,6 +48,7 @@
 import java.net.URI;
 import java.net.URISyntaxException;
 import java.net.URL;
+import java.util.concurrent.TimeUnit;
 
 public class ApacheHttpClient implements org.openqa.selenium.remote.http.HttpClient {
 
@@ -253,4 +254,10 @@ private static synchronized HttpClientFactory getDefaultHttpClientFactory() {
       return defaultClientFactory;
     }
   }
+  
+  @Override
+	public void close() throws IOException {
+	  client.getConnectionManager().closeIdleConnections(0, TimeUnit.SECONDS);		
+	}
+  
 }