Allow repeated repeatable directives

Author: rmosolgo

lib/graphql/static_validation/base_visitor.rb

@@ -110,7 +110,7 @@ def on_field(node, parent)
         end
 
         def on_directive(node, parent)
-          directive_defn = @schema.directives[node.name]
+          directive_defn = @context.schema_directives[node.name]
           @directive_definitions.push(directive_defn)
           super
           @directive_definitions.pop

lib/graphql/static_validation/rules/arguments_are_defined.rb

@@ -59,7 +59,7 @@ def parent_definition(parent)
             end
           end
         when GraphQL::Language::Nodes::Directive
-          context.schema.directives[parent.name]
+          context.schema_directives[parent.name]
         when GraphQL::Language::Nodes::Field
           context.field_definition
         else

lib/graphql/static_validation/rules/directives_are_in_valid_locations.rb

@@ -5,7 +5,7 @@ module DirectivesAreInValidLocations
       include GraphQL::Language
 
       def on_directive(node, parent)
-        validate_location(node, parent, context.schema.directives)
+        validate_location(node, parent, context.schema_directives)
         super
       end
 

lib/graphql/static_validation/rules/required_arguments_are_present.rb

@@ -8,7 +8,7 @@ def on_field(node, _parent)
       end
 
       def on_directive(node, _parent)
-        directive_defn = context.schema.directives[node.name]
+        directive_defn = context.schema_directives[node.name]
         assert_required_args(node, directive_defn)
         super
       end

lib/graphql/static_validation/rules/unique_directives_per_location.rb

@@ -40,7 +40,7 @@ def validate_directive_location(node)
               nodes: [used_directives[directive_name], ast_directive],
               directive: directive_name,
             ))
-          else
+          elsif !((dir_defn = context.schema_directives[directive_name]) && dir_defn.repeatable?)
             used_directives[directive_name] = ast_directive
           end
         end

lib/graphql/static_validation/validation_context.rb

@@ -44,6 +44,10 @@ def validate_literal(ast_value, type)
       def too_many_errors?
         @errors.length >= @max_errors
       end
+
+      def schema_directives
+        @schema_directives ||= schema.directives
+      end
     end
   end
 end

spec/graphql/static_validation/rules/unique_directives_per_location_spec.rb

@@ -15,6 +15,7 @@
 
     directive @A on FIELD
     directive @B on FIELD
+    directive @C repeatable on FIELD
   ") }
 
   describe "query with no directives" do
@@ -31,6 +32,20 @@
     end
   end
 
+  describe "query with repeatable directives" do
+    let(:query_string) {"
+      {
+        type {
+          field @C @C @C
+        }
+      }
+    "}
+
+    it "passes rule" do
+      assert_equal [], errors
+    end
+  end
+
   describe "query with unique directives in different locations" do
     let(:query_string) {"
       {