Merge pull request googleworkspace#107 from matheusbn/master

Eric Koleda · web-flow · commit afa09535dc3c · 2019-03-26T08:37:14.000-04:00
Simplify condition
diff --git a/docs/translate/translate.gs b/docs/translate/translate.gs
@@ -73,8 +73,8 @@ function showSidebar() {
  */
 function getSelectedText() {
   var selection = DocumentApp.getActiveDocument().getSelection();
+  var text = [];
   if (selection) {
-    var text = [];
     var elements = selection.getSelectedElements();
     for (var i = 0; i < elements.length; ++i) {
       if (elements[i].isPartial()) {
@@ -97,13 +97,9 @@ function getSelectedText() {
         }
       }
     }
-    if (!text.length) {
-      throw new Error('Please select some text.');
-    }
-    return text;
-  } else {
-    throw new Error('Please select some text.');
   }
+  if (!text.length) throw new Error('Please select some text.');
+  return text;
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -73,8 +73,8 @@ function showSidebar() {`
`73`	`73`	`*/`
`74`	`74`	`function getSelectedText() {`
`75`	`75`	`var selection = DocumentApp.getActiveDocument().getSelection();`
	`76`	`+ var text = [];`
`76`	`77`	`if (selection) {`
`77`		`- var text = [];`
`78`	`78`	`var elements = selection.getSelectedElements();`
`79`	`79`	`for (var i = 0; i < elements.length; ++i) {`
`80`	`80`	`if (elements[i].isPartial()) {`
`@@ -97,13 +97,9 @@ function getSelectedText() {`
`97`	`97`	`}`
`98`	`98`	`}`
`99`	`99`	`}`
`100`		`- if (!text.length) {`
`101`		`- throw new Error('Please select some text.');`
`102`		`- }`
`103`		`- return text;`
`104`		`- } else {`
`105`		`- throw new Error('Please select some text.');`
`106`	`100`	`}`
	`101`	`+ if (!text.length) throw new Error('Please select some text.');`
	`102`	`+ return text;`
`107`	`103`	`}`
`108`	`104`
`109`	`105`	`/**`