Caching the size/length in loops to slightly improve performance (SeleniumHQ#15852)

caching the size/length in loops to slightly improve performance and readability

Co-authored-by: Diego Molina <[email protected]>

Author: LuisOsv

java/src/dev/selenium/tools/javadoc/JavadocJarMaker.java

@@ -55,7 +55,8 @@ public static void main(String[] args) throws IOException {
     Path out = null;
     Set<Path> classpath = new HashSet<>();
 
-    for (int i = 0; i < args.length; i++) {
+    int argCount = args.length;
+    for (int i = 0; i < argCount; i++) {
       String flag = args[i];
       String next = args[++i];
 

java/src/dev/selenium/tools/modules/ModuleGenerator.java

@@ -108,7 +108,8 @@ public static void main(String[] args) throws IOException {
     Set<String> openTo = new TreeSet<>();
     boolean isOpen = false;
 
-    for (int i = 0; i < args.length; i++) {
+    int argCount = args.length;
+    for (int i = 0; i < argCount; i++) {
       String flag = args[i];
       String next = args[++i];
       switch (flag) {

java/src/org/openqa/selenium/grid/node/docker/DockerOptions.java

@@ -140,10 +140,11 @@ public Map<Capabilities, Collection<SessionFactory>> getDockerSessionFactories(
         config.getAll(DOCKER_SECTION, "host-config-keys").orElseGet(Collections::emptyList);
 
     Multimap<String, Capabilities> kinds = HashMultimap.create();
-    for (int i = 0; i < allConfigs.size(); i++) {
+    int configsCount = allConfigs.size();
+    for (int i = 0; i < configsCount; i++) {
       String imageName = allConfigs.get(i);
       i++;
-      if (i == allConfigs.size()) {
+      if (i == configsCount) {
         throw new DockerException("Unable to find JSON config");
       }
       Capabilities stereotype =

java/src/org/openqa/selenium/grid/node/relay/RelayOptions.java

@@ -153,15 +153,16 @@ public Map<Capabilities, Collection<SessionFactory>> getSessionFactories(
                 () -> new ConfigException("Unable to find configs for " + getServiceUri()));
 
     Multimap<Integer, Capabilities> parsedConfigs = HashMultimap.create();
-    for (int i = 0; i < allConfigs.size(); i++) {
+    int configsCount = allConfigs.size();
+    for (int i = 0; i < configsCount; i++) {
       int maxSessions;
       try {
         maxSessions = Integer.parseInt(extractConfiguredValue(allConfigs.get(i)));
       } catch (NumberFormatException e) {
         throw new ConfigException("Unable parse value as number. " + allConfigs.get(i));
       }
       i++;
-      if (i == allConfigs.size()) {
+      if (i == configsCount) {
         throw new ConfigException("Unable to find stereotype config. " + allConfigs);
       }
       Capabilities stereotype =

java/src/org/openqa/selenium/json/JsonInput.java

@@ -507,7 +507,8 @@ private void expect(JsonType type) {
   private <X> X read(String toCompare, Function<String, X> mapper) {
     skipWhitespace(input);
 
-    for (int i = 0; i < toCompare.length(); i++) {
+    int toCompareLength = toCompare.length();
+    for (int i = 0; i < toCompareLength; i++) {
       char read = input.read();
       if (read != toCompare.charAt(i)) {
         throw new JsonException(

java/src/org/openqa/selenium/remote/WebElementToJsonConverter.java

@@ -85,7 +85,8 @@ public Object apply(Object arg) {
 
   private static List<Object> arrayToList(Object array) {
     List<Object> list = new ArrayList<>();
-    for (int i = 0; i < Array.getLength(array); i++) {
+    int arrayLength = Array.getLength(array);
+    for (int i = 0; i < arrayLength; i++) {
       list.add(Array.get(array, i));
     }
     return list;

java/src/org/openqa/selenium/remote/codec/AbstractHttpCommandCodec.java

@@ -387,11 +387,12 @@ boolean isFor(HttpMethod method, List<String> parts) {
         return false;
       }
 
-      if (parts.size() != this.pathSegments.size()) {
+      int partsCount = parts.size();
+      if (partsCount != this.pathSegments.size()) {
         return false;
       }
 
-      for (int i = 0; i < parts.size(); ++i) {
+      for (int i = 0; i < partsCount; ++i) {
         String reqPart = parts.get(i);
         String specPart = pathSegments.get(i);
         if (!(specPart.startsWith(":") || specPart.equals(reqPart))) {
@@ -403,7 +404,8 @@ boolean isFor(HttpMethod method, List<String> parts) {
     }
 
     void parsePathParameters(List<String> parts, Map<String, Object> parameters) {
-      for (int i = 0; i < parts.size(); ++i) {
+      int partsCount = parts.size();
+      for (int i = 0; i < partsCount; ++i) {
         if (pathSegments.get(i).startsWith(":")) {
           parameters.put(pathSegments.get(i).substring(1), parts.get(i));
         }

java/src/org/openqa/selenium/remote/http/Route.java

@@ -254,10 +254,11 @@ public boolean matches(HttpRequest request) {
 
     private boolean hasPrefix(HttpRequest request) {
       String[] parts = request.getUri().split("/");
-      if (parts.length < prefixPaths.length) {
+      int prefixPathCount = prefixPaths.length;
+      if (parts.length < prefixPathCount) {
         return false;
       }
-      for (int i = 0; i < prefixPaths.length; i++) {
+      for (int i = 0; i < prefixPathCount; i++) {
         if (!prefixPaths[i].equals(parts[i])) {
           return false;
         }

java/src/org/openqa/selenium/remote/http/UrlTemplate.java

@@ -69,7 +69,8 @@ public UrlTemplate(String template) {
 
     List<String> allGroups = List.copyOf(groups);
     // do we hit a fast path?
-    switch (allGroups.size()) {
+    int groupsCount = allGroups.size();
+    switch (groupsCount) {
       case 0: // no groups, just .equals
         this.compiled =
             (matchAgainst) -> {
@@ -119,7 +120,7 @@ public UrlTemplate(String template) {
               }
 
               Map<String, String> params = new LinkedHashMap<>();
-              for (int i = 0; i < allGroups.size(); i++) {
+              for (int i = 0; i < groupsCount; i++) {
                 params.put(allGroups.get(i), matcher.group(i + 1));
               }