Skip to content

Commit bd86544

Browse files
committed
Use SYMFONY_VERSION as a variable name everywhere to avoid mistakes
1 parent d9541dc commit bd86544

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ ARG STABILITY=stable
4040
ENV STABILITY ${STABILITY}
4141

4242
# Allow to select skeleton version
43-
ARG VERSION=""
43+
ARG SYMFONY_VERSION=""
4444

4545
# Download the Symfony skeleton and leverage Docker cache layers
46-
RUN composer create-project "symfony/skeleton ${VERSION}" . --stability=$STABILITY --prefer-dist --no-dev --no-progress --no-scripts --no-plugins --no-interaction
46+
RUN composer create-project "symfony/skeleton ${SYMFONY_VERSION}" . --stability=$STABILITY --prefer-dist --no-dev --no-progress --no-scripts --no-plugins --no-interaction
4747

4848
###> recipes ###
4949
###< recipes ###

docker-compose.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ services:
55
build:
66
context: .
77
args:
8-
VERSION: ${SYMFONY_VERSION}
8+
SYMFONY_VERSION: ${SYMFONY_VERSION}
99
STABILITY: stable
1010
volumes:
1111
# Comment out the next line in production
@@ -15,6 +15,8 @@ services:
1515
- /srv/app/var/cache/
1616
- /srv/app/var/logs/
1717
- /srv/app/var/sessions/
18+
environment:
19+
- SYMFONY_VERSION
1820

1921
nginx:
2022
build:

docker/app/docker-entrypoint.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ fi
99
if [ "$1" = 'php-fpm' ] || [ "$1" = 'bin/console' ]; then
1010
# The first time volumes are mounted, the project needs to be recreated
1111
if [ ! -f composer.json ]; then
12-
composer create-project "symfony/skeleton $VERSION" tmp --stability=$STABILITY --prefer-dist --no-progress --no-interaction
12+
composer create-project "symfony/skeleton $SYMFONY_VERSION" tmp --stability=$STABILITY --prefer-dist --no-progress --no-interaction
1313
cp -Rp tmp/. .
1414
rm -Rf tmp/
1515
elif [ "$APP_ENV" != 'prod' ]; then

0 commit comments

Comments
 (0)