Skip to content

[Database] Add additional test cases for database operations introduced in #95 #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
frisitano opened this issue May 7, 2025 · 0 comments
Open

[Database] Add additional test cases for database operations introduced in #95 #102

frisitano opened this issue May 7, 2025 · 0 comments
Assignees
@colinlyguo
Labels
database enhancement New feature or request milestone 5 This issue is part to Milestone 5 of the Rollup Node plan
Milestone
Milestone 5

Comments

@frisitano
Copy link
Collaborator

Overview

In #95 we introduced/modified several methods on the database (show in the diff here). We should introduce some additional test cases to add coverage for these methods. Specifically:

  • delete_l1_messages_gt
  • get_l2_block_info_by_number
  • get_latest_safe_l2_block
  • get_latest_l2_block
  • delete_l2_blocks_gt
  • insert_block

Tests should be implemented here following the standards of pre-existing test cases.
@frisitano frisitano added this to the Milestone 5 milestone May 7, 2025
@frisitano frisitano added enhancement New feature or request milestone 5 This issue is part to Milestone 5 of the Rollup Node plan labels May 7, 2025
@frisitano frisitano added this to Reth May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colinlyguo colinlyguo

Labels
database enhancement New feature or request milestone 5 This issue is part to Milestone 5 of the Rollup Node plan
Projects
Reth
Status: No status
Milestone
Milestone 5
Development

No branches or pull requests
2 participants
@frisitano @colinlyguo