Skip to content

[Indexer] Make Indexer lockless #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
frisitano opened this issue May 14, 2025 · 0 comments
Open

[Indexer] Make Indexer lockless #114

frisitano opened this issue May 14, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@frisitano
Copy link
Collaborator

Overview

We should remove the Mutex locks in the Indexer:

rollup-node/crates/indexer/src/lib.rs

Lines 40 to 44 in cc614c5

/// The block number of the L1 finalized block.
l1_finalized_block_number: Arc<Mutex<u64>>,
/// The block number of the L2 finalized block.
l2_finalized_block_number: Arc<Mutex<u64>>,
/// The chain specification for the indexer.

We should replace them with AtomicU64. This will yield a solution without any locks required.
@frisitano frisitano added the enhancement New feature or request label May 14, 2025
@frisitano frisitano added this to Reth May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Reth
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@frisitano