Skip to content

[Consensus] Disambiguate ConsensusError::Signer #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
frisitano opened this issue Apr 24, 2025 · 0 comments
Open

[Consensus] Disambiguate ConsensusError::Signer #78

frisitano opened this issue Apr 24, 2025 · 0 comments
Assignees
@greged93
Labels
enhancement New feature or request milestone 5 This issue is part to Milestone 5 of the Rollup Node plan node
Milestone
Milestone 5

Comments

@frisitano
Copy link
Collaborator

Overview

Currently, we raise a ConsensusError::Signature in two cases:

  • When a signature cannot be recovered
  • When a signature is associated with a signer who is not authorized to author blocks

We should disambiguate these cases with distinct errors.
@frisitano frisitano added enhancement New feature or request milestone 5 This issue is part to Milestone 5 of the Rollup Node plan node labels Apr 24, 2025
@frisitano frisitano added this to the Milestone 5 milestone Apr 24, 2025
@frisitano frisitano added this to Reth Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greged93 greged93

Labels
enhancement New feature or request milestone 5 This issue is part to Milestone 5 of the Rollup Node plan node
Projects
Reth
Status: No status
Milestone
Milestone 5
Development

No branches or pull requests
2 participants
@frisitano @greged93