Skip to content

[Engine] Event for L1 consolidation reorg #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frisitano opened this issue Apr 29, 2025 · 0 comments
Open

[Engine] Event for L1 consolidation reorg #94

frisitano opened this issue Apr 29, 2025 · 0 comments
Labels
bug Something isn't working database engine milestone 5 This issue is part to Milestone 5 of the Rollup Node plan
Milestone

Comments

@frisitano
Copy link
Collaborator

Overview

If we reorg during L1 Consolidation, we should update the RNM so that we can make other components consistent with the EngineDriver. We should introduce a new event type EngineDriverEvent::L1BlockReorg and emit it.

EngineDriverFutureResult::L1Consolidation(result) => {
tracing::info!(target: "scroll::engine", ?result, "handling L1 consolidation result");
match result {
Ok((block_info, reorg, batch_info)) => {
// Update the safe block info and return the block info
tracing::trace!(target: "scroll::engine", ?block_info, "updating safe block info from block derived from L1");
self.fcs.update_safe_block_info(block_info);
// If we reorged, update the head block info
if reorg {
tracing::warn!(target: "scroll::engine", ?block_info, "reorging head to l1 derived block");
self.fcs.update_head_block_info(block_info);
}
return Some(EngineDriverEvent::L1BlockConsolidated((
block_info, batch_info,
)))
}

@frisitano frisitano added this to the Milestone 5 milestone Apr 29, 2025
@frisitano frisitano added this to Reth Apr 29, 2025
@frisitano frisitano added bug Something isn't working milestone 5 This issue is part to Milestone 5 of the Rollup Node plan database engine labels Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working database engine milestone 5 This issue is part to Milestone 5 of the Rollup Node plan
Projects
Status: No status
Development

No branches or pull requests

1 participant