Skip to content

Commit 8f4ab01

Browse files
gazpachuArtem Sapegin
authored and
Artem Sapegin
committed
Fix: Allow custom styling for prop names and types (styleguidist#1211)
Closes styleguidist#1205
1 parent bf72b4b commit 8f4ab01

File tree

4 files changed

+13
-27
lines changed

4 files changed

+13
-27
lines changed

src/client/rsg-components/Name/NameRenderer.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import React from 'react';
22
import PropTypes from 'prop-types';
3-
import Code from 'rsg-components/Code';
43
import Styled from 'rsg-components/Styled';
54
import cx from 'classnames';
65

7-
export const styles = ({ fontSize, color }) => ({
6+
export const styles = ({ fontFamily, fontSize, color }) => ({
87
name: {
8+
fontFamily: fontFamily.monospace,
99
fontSize: fontSize.small,
1010
color: color.name,
1111
},
@@ -19,11 +19,7 @@ export function NameRenderer({ classes, children, deprecated }) {
1919
const classNames = cx(classes.name, {
2020
[classes.isDeprecated]: deprecated,
2121
});
22-
return (
23-
<span className={classNames}>
24-
<Code>{children}</Code>
25-
</span>
26-
);
22+
return <code className={classNames}>{children}</code>;
2723
}
2824

2925
NameRenderer.propTypes = {
Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,17 @@
11
// Jest Snapshot v1, https://goo.gl/fbAQLP
22

33
exports[`renderer should render argument name 1`] = `
4-
<span
4+
<code
55
className="name"
66
>
7-
<Styled(Code)>
8-
Foo
9-
</Styled(Code)>
10-
</span>
7+
Foo
8+
</code>
119
`;
1210

1311
exports[`renderer should render deprecated argument name 1`] = `
14-
<span
12+
<code
1513
className="name isDeprecated"
1614
>
17-
<Styled(Code)>
18-
Foo
19-
</Styled(Code)>
20-
</span>
15+
Foo
16+
</code>
2117
`;

src/client/rsg-components/Type/TypeRenderer.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,17 @@
11
import React from 'react';
22
import PropTypes from 'prop-types';
3-
import Code from 'rsg-components/Code';
43
import Styled from 'rsg-components/Styled';
54

6-
export const styles = ({ fontSize, color }) => ({
5+
export const styles = ({ fontFamily, fontSize, color }) => ({
76
type: {
7+
fontFamily: fontFamily.monospace,
88
fontSize: fontSize.small,
99
color: color.type,
1010
},
1111
});
1212

1313
export function TypeRenderer({ classes, children }) {
14-
return (
15-
<span className={classes.type}>
16-
<Code>{children}</Code>
17-
</span>
18-
);
14+
return <span className={classes.type}>{children}</span>;
1915
}
2016

2117
TypeRenderer.propTypes = {

src/client/rsg-components/Type/__snapshots__/Type.spec.js.snap

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ exports[`renderer should render type 1`] = `
44
<span
55
className="type"
66
>
7-
<Styled(Code)>
8-
Array
9-
</Styled(Code)>
7+
Array
108
</span>
119
`;

0 commit comments

Comments
 (0)