Skip to content

Commit ccfa422

Browse files
committed
Fix compilation of kotlin-script-util
'check' was removed in 579238c
1 parent 84c473d commit ccfa422

File tree

3 files changed

+9
-16
lines changed

3 files changed

+9
-16
lines changed

libraries/tools/kotlin-script-util/src/main/kotlin/org/jetbrains/kotlin/script/util/resolve.kt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,7 @@ import org.jetbrains.kotlin.script.util.resolvers.DirectResolver
2121
import org.jetbrains.kotlin.script.util.resolvers.FlatLibDirectoryResolver
2222
import org.jetbrains.kotlin.script.util.resolvers.MavenResolver
2323
import org.jetbrains.kotlin.script.util.resolvers.Resolver
24-
import org.jetbrains.kotlin.utils.addToStdlib.check
2524
import java.io.File
26-
import java.lang.Exception
27-
import java.lang.IllegalArgumentException
2825
import java.util.concurrent.Future
2926

3027
open class KotlinAnnotatedScriptDependenciesResolver(val baseClassPath: List<File>, resolvers: Iterable<Resolver>)
@@ -53,7 +50,7 @@ open class KotlinAnnotatedScriptDependenciesResolver(val baseClassPath: List<Fil
5350
script.annotations.forEach { annotation ->
5451
when (annotation) {
5552
is Repository -> FlatLibDirectoryResolver.tryCreate(annotation)?.apply { resolvers.add(this) }
56-
?: resolvers.find { it is MavenResolver }?.check { (it as MavenResolver).tryAddRepo(annotation) }
53+
?: resolvers.find { it is MavenResolver }?.takeIf { (it as MavenResolver).tryAddRepo(annotation) }
5754
?: throw IllegalArgumentException("Illegal argument for Repository annotation: $annotation")
5855
is DependsOn -> {}
5956
is InvalidScriptResolverAnnotation -> throw Exception("Invalid annotation ${annotation.name}", annotation.error)

libraries/tools/kotlin-script-util/src/main/kotlin/org/jetbrains/kotlin/script/util/resolvers/basic.kt

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,15 @@ package org.jetbrains.kotlin.script.util.resolvers
1818

1919
import org.jetbrains.kotlin.script.util.DependsOn
2020
import org.jetbrains.kotlin.script.util.Repository
21-
import org.jetbrains.kotlin.utils.addToStdlib.check
2221
import java.io.File
23-
import java.lang.IllegalArgumentException
2422

2523
interface Resolver {
2624
fun tryResolve(dependsOn: DependsOn): Iterable<File>?
2725
}
2826

2927
class DirectResolver : Resolver {
3028
override fun tryResolve(dependsOn: DependsOn): Iterable<File>? =
31-
dependsOn.value.check(String::isNotBlank)?.let(::File)?.check { it.exists() && (it.isFile || it.isDirectory) }?.let { listOf(it) }
29+
dependsOn.value.takeUnless(String::isBlank)?.let(::File)?.takeIf { it.exists() && (it.isFile || it.isDirectory) }?.let { listOf(it) }
3230
}
3331

3432
class FlatLibDirectoryResolver(val path: File) : Resolver {
@@ -39,10 +37,10 @@ class FlatLibDirectoryResolver(val path: File) : Resolver {
3937

4038
override fun tryResolve(dependsOn: DependsOn): Iterable<File>? =
4139
// TODO: add coordinates and wildcard matching
42-
dependsOn.value.check(String::isNotBlank)?.let{ File(path, it) }?.check { it.exists() && (it.isFile || it.isDirectory) }?.let { listOf(it) }
40+
dependsOn.value.takeUnless(String::isBlank)?.let { File(path, it) }?.takeIf { it.exists() && (it.isFile || it.isDirectory) }?.let { listOf(it) }
4341

4442
companion object {
4543
fun tryCreate(annotation: Repository): FlatLibDirectoryResolver? =
46-
annotation.value.check(String::isNotBlank)?.let(::File)?.check { it.exists() && it.isDirectory }?.let(::FlatLibDirectoryResolver)
44+
annotation.value.takeUnless(String::isBlank)?.let(::File)?.takeIf { it.exists() && it.isDirectory }?.let(::FlatLibDirectoryResolver)
4745
}
4846
}

libraries/tools/kotlin-script-util/src/main/kotlin/org/jetbrains/kotlin/script/util/resolvers/maven.kt

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,14 @@ package org.jetbrains.kotlin.script.util.resolvers
2121
import com.jcabi.aether.Aether
2222
import org.jetbrains.kotlin.script.util.DependsOn
2323
import org.jetbrains.kotlin.script.util.Repository
24-
import org.jetbrains.kotlin.utils.addToStdlib.check
25-
import org.jetbrains.kotlin.utils.rethrow
26-
import java.io.File
27-
import java.util.*
2824
import org.sonatype.aether.repository.RemoteRepository
2925
import org.sonatype.aether.resolution.DependencyResolutionException
3026
import org.sonatype.aether.util.artifact.DefaultArtifact
3127
import org.sonatype.aether.util.artifact.JavaScopes
28+
import java.io.File
3229
import java.net.MalformedURLException
3330
import java.net.URL
31+
import java.util.*
3432

3533
val mavenCentral = RemoteRepository("maven-central", "default", "http://repo1.maven.org/maven2/")
3634

@@ -51,7 +49,7 @@ class MavenResolver(val reportError: ((String) -> Unit)? = null): Resolver {
5149
reportError?.invoke(msg) ?: throw RuntimeException(msg)
5250
}
5351

54-
fun String?.orNullIfBlank(): String? = this?.check(String::isNotBlank)
52+
fun String?.orNullIfBlank(): String? = this?.takeUnless(String::isBlank)
5553

5654
val artifactId: DefaultArtifact = when {
5755
dependsOn.groupId.isValidParam() || dependsOn.artifactId.isValidParam() -> {
@@ -75,13 +73,13 @@ class MavenResolver(val reportError: ((String) -> Unit)? = null): Resolver {
7573
}
7674
}
7775
catch (e: DependencyResolutionException) {
78-
reportError?.invoke("resolving ${artifactId.artifactId} failed: $e") ?: rethrow(e)
76+
reportError?.invoke("resolving ${artifactId.artifactId} failed: $e") ?: throw e
7977
}
8078
return null
8179
}
8280

8381
fun tryAddRepo(annotation: Repository): Boolean {
84-
val urlStr = annotation.url.check { it.isValidParam() } ?: annotation.value.check { it.isValidParam() } ?: return false
82+
val urlStr = annotation.url.takeIf { it.isValidParam() } ?: annotation.value.takeIf { it.isValidParam() } ?: return false
8583
try {
8684
URL(urlStr)
8785
} catch (_: MalformedURLException) {

0 commit comments

Comments
 (0)