iron out midi install

Author: nir

README.md

@@ -85,10 +85,6 @@ console:
 
     pip install jupylet
 
-To install it with MIDI support type the following command instead:
-
-    pip install jupylet[midi]
-
 If you are using Python 3.8 on Windows you also need to run following command:
 
     python -m jupylet postinstall

docs/programmers_reference_guide/getting_started.rst

@@ -24,12 +24,6 @@ console:
 
     pip install jupylet
 
-To install it with MIDI support type the following command instead:
-
-.. code-block:: bash
-
-    pip install jupylet[midi]
-
 If you are using Python 3.8 on Windows you also need to run following command:
 
 .. code-block:: bash

jupylet/__init__.py

@@ -48,7 +48,7 @@
       sys.stderr.write(
          'WARNING: numpy was imported before jupylet. ' + 
          'On Mac OS X you should import jupylet first to let it work around ' +
-         'a bug in the algebra libraries used by numpy, that may cause the ' +
+         'a bug in the algebra libraries used by numpy that may cause the ' +
          'program to exit.' + '\n'
       )
 

jupylet/app.py

@@ -264,11 +264,13 @@ def set_midi_sound(self, s):
             s (jupylet.audio.sound.Sound): The sound object to use as MIDI 
                 instrument.
         """
-        midi.set_midi_sound(s)
-        midi.set_midi_callback(midi.simple_midi_callback)
-        
-        self.scheduler.unschedule(midi.midi_port_handler)
-        self.scheduler.schedule_interval(midi.midi_port_handler, 1)
+        if midi.test_rtmidi():
+            
+            midi.set_midi_sound(s)
+            midi.set_midi_callback(midi.simple_midi_callback)
+            
+            self.scheduler.unschedule(midi.midi_port_handler)
+            self.scheduler.schedule_interval(midi.midi_port_handler, 1)
 
     @property
     def width(self):

jupylet/audio/midi.py

@@ -27,17 +27,13 @@
 #
 # python-rtmidi requires the following command on ubuntu:
 # sudo apt-get install libasound2-dev libjack-dev build-essentials
-# And extend setup.py with extras for midi to avoid setup crash on ubuntu.
 #
 
-import functools
-import _thread
 import logging
 
 try:
     import rtmidi
     import mido
-
 except:
     rtmidi = None
     mido = None
@@ -46,6 +42,19 @@
 logger = logging.getLogger(__name__)
 
 
+def test_rtmidi():
+
+    if rtmidi:
+        return True
+
+    logger.warning(
+        'Module python-rtmidi is not installed. To install it on Ubuntu ' + 
+        'Linux run these commands:\n' +
+        '$ sudo apt-get install libasound2-dev libjack-dev build-essentials\n' +
+        '$ pip install python-rtmidi'
+    )
+
+
 _port = None
 
 

setup.py

@@ -38,9 +38,10 @@
     python_requires='>=3.6, <3.9',
     install_requires=[
         'glfw',
+        'mido',
         'wget',
-        'numpy==1.19.3 ; platform_system=="Windows"',
         'numpy ; platform_system!="Windows"', 
+        'numpy==1.19.3 ; platform_system=="Windows"',
         'PyGLM',
         'scipy', 
         'pillow', 
@@ -54,10 +55,11 @@
         'matplotlib', 
         'sounddevice', 
         'scikit-image',
+        'python-rtmidi ; platform_system!="Linux"',
         'moderngl-window',
     ],
     extras_require = {
-        'midi': ['mido', 'python-rtmidi']
+        'midi': ['python-rtmidi']
     },
     classifiers=[
         'Development Status :: 4 - Beta',