You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We appreciate the effort for this pull request but before that please make sure you read the contribution guidelines given above, then fill out the blanks below.
3
+
4
+
5
+
Please enter each Issue number you are resolving in your PR after one of the following words [Fixes, Closes, Resolves]. This will auto-link these issues and close them when this PR is merged!
6
+
e.g.
7
+
Fixes #1
8
+
Closes #2
9
+
-->
10
+
# Fixes #
11
+
12
+
### Checklist
13
+
- [ ] I have made a material change to the repo (functionality, testing, spelling, grammar)
14
+
- [ ] I have read the [Contribution Guide] and my PR follows them.
15
+
- [ ] I updated my branch with the master branch.
16
+
- [ ] I have added tests that prove my fix is effective or that my feature works
17
+
- [ ] I have added necessary documentation about the functionality in the appropriate .md file
18
+
- [ ] I have added in line documentation to the code I modified
19
+
20
+
### Short description of what this PR does:
21
+
-
22
+
-
23
+
24
+
If you have questions, please send an email to [Sendgrid](mailto:[email protected]), or file a Github Issue in this repository.
The SendGrid open source community is made up of members from around the globe with a diverse set of skills, personalities, and experiences. It is through these differences that our community experiences successes and continued growth. When you're working with members of the community, we encourage you to follow these guidelines, which help steer our interactions and strive to maintain a positive, successful and growing community.
4
+
5
+
### Be Open
6
+
Members of the community are open to collaboration, whether it's on pull requests, code reviews, approvals, issues or otherwise. We're receptive to constructive comments and criticism, as the experiences and skill sets of all members contribute to the whole of our efforts. We're accepting of all who wish to take part in our activities, fostering an environment where anyone can participate, and everyone can make a difference.
7
+
8
+
### Be Considerate
9
+
Members of the community are considerate of their peers, which include other contributors and users of SendGrid. We're thoughtful when addressing the efforts of others, keeping in mind that often the labor was completed with the intent of the good of the community. We're attentive in our communications, whether in person or online, and we're tactful when approaching differing views.
10
+
11
+
### Be Respectful
12
+
Members of the community are respectful. We're respectful of others, their positions, their skills, their commitments and their efforts. We're respectful of the volunteer efforts that permeate the SendGrid community. We're respectful of the processes outlined in the community, and we work within them. When we disagree, we are courteous in raising our issues. Overall, we're good to each other. We contribute to this community not because we have to, but because we want to. If we remember that, these guidelines will come naturally.
13
+
14
+
## Additional Guidance
15
+
16
+
### Disclose Potential Conflicts of Interest
17
+
Community discussions often involve interested parties. We expect participants to be aware when they are conflicted due to employment or other projects they are involved in and disclose those interests to other project members. When in doubt, over-disclose. Perceived conflicts of interest are important to address so that the community’s decisions are credible even when unpopular, difficult or favorable to the interests of one group over another.
18
+
19
+
### Interpretation
20
+
This Code is not exhaustive or complete. It is not a rulebook; it serves to distill our common understanding of a collaborative, shared environment and goals. We expect it to be followed in spirit as much as in the letter. When in doubt, try to abide by [SendGrid’s cultural values](https://sendgrid.com/blog/employee-engagement-the-4h-way) defined by our “4H’s”: Happy, Hungry, Humble and Honest.
21
+
22
+
### Enforcement
23
+
Most members of the SendGrid community always comply with this Code, not because of the existence of this Code, but because they have long experience participating in open source communities where the conduct described above is normal and expected. However, failure to observe this Code may be grounds for suspension, reporting the user for abuse or changing permissions for outside contributors.
24
+
25
+
## If you have concerns about someone’s conduct
26
+
**Initiate Direct Contact** - It is always appropriate to email a community member (if contact information is available), mention that you think their behavior was out of line, and (if necessary) point them to this Code.
27
+
28
+
**Discuss Publicly** - Discussing publicly is always acceptable. Note, though, that approaching the person directly may be better, as it tends to make them less defensive, and it respects the time of other community members, so you probably want to try direct contact first.
29
+
30
+
**Contact the Moderators** - You can reach the SendGrid moderators by emailing [email protected].
31
+
32
+
## Submission to SendGrid Repositories
33
+
Finally, just a reminder, changes to the SendGrid repositories will only be accepted upon completion of the [SendGrid Contributor Agreement](https://cla.sendgrid.com).
34
+
35
+
## Attribution
36
+
37
+
SendGrid thanks the following, on which it draws for content and inspiration:
38
+
39
+
*[Python Community Code of Conduct](https://www.python.org/psf/codeofconduct/)
40
+
*[Open Source Initiative General Code of Conduct](https://opensource.org/codeofconduct)
41
+
*[Apache Code of Conduct](https://www.apache.org/foundation/policies/conduct.html)
-[Creating a Pull Request](#creating-a-pull-request)
12
12
13
13
<aname="roadmap"></a>
14
14
We use [Milestones](https://github.com/sendgrid/java-http-client/milestones) to help define current roadmaps, please feel free to grab an issue from the current milestone. Please indicate that you have begun work on it to avoid collisions. Once a PR is made, community review, comments, suggestions and additional PRs are welcomed and encouraged.
@@ -26,7 +26,7 @@ When you create a Pull Request, after a few seconds, a comment will appear with
26
26
27
27
There are a few ways to contribute, which we'll enumerate below:
28
28
29
-
<aname="feature_request"></a>
29
+
<aname="feature-request"></a>
30
30
## Feature Request
31
31
32
32
If you'd like to make a feature request, please read this section.
@@ -36,7 +36,7 @@ The GitHub issue tracker is the preferred channel for library feature requests,
36
36
- Please **search for existing issues** in order to ensure we don't have duplicate bugs/feature requests.
37
37
- Please be respectful and considerate of others when commenting on issues
38
38
39
-
<aname="submit_a_bug_report"></a>
39
+
<aname="submit-a-bug-report"></a>
40
40
## Submit a Bug Report
41
41
42
42
Note: DO NOT include your credentials in ANY code examples, descriptions, or media you make public.
@@ -53,7 +53,7 @@ Before you decide to create a new issue, please try the following:
53
53
54
54
In order to make the process easier, we've included a [sample bug report template](https://github.com/sendgrid/java-http-client/.github/ISSUE_TEMPLATE) (borrowed from [Ghost](https://github.com/TryGhost/Ghost/)). The template uses [GitHub flavored markdown](https://help.github.com/articles/github-flavored-markdown/) for formatting.
55
55
56
-
<aname="improvements_to_the_codebase"></a>
56
+
<aname="improvements-to-the-codebase"></a>
57
57
## Improvements to the Codebase
58
58
59
59
We welcome direct contributions to the java-http-client code base. Thank you!
@@ -64,7 +64,7 @@ We welcome direct contributions to the java-http-client code base. Thank you!
64
64
65
65
##### Prerequisites #####
66
66
67
-
- Java version Oracle JDK 7, 8 or OpenJDK 7
67
+
- Java version Oracle JDK 8 or OpenJDK 7
68
68
- Please see [build.gradle](https://github.com/sendgrid/java-http-client/blob/master/build.gradle)
69
69
70
70
##### Initial setup: #####
@@ -89,10 +89,10 @@ source ./sendgrid.env
89
89
```bash
90
90
./gradlew build
91
91
cd examples
92
-
javac -classpath {path_to}/sendgrid-java-http-client-4.1.0-jar.jar:. Example.java && java -classpath {path_to}/sendgrid-java-http-client-4.1.0-jar.jar:. Example
92
+
javac -classpath {path_to}/sendgrid-java-http-client-4.2.0-jar.jar:. Example.java && java -classpath {path_to}/sendgrid-java-http-client-4.2.0-jar.jar:. Example
Generally, we follow the style guidelines as suggested by the official language. However, we ask that you conform to the styles that already exist in the library. If you wish to deviate, please explain your reasoning.
@@ -141,8 +141,8 @@ Please run your code through:
141
141
-[FindBugs](http://findbugs.sourceforge.net/)
142
142
-[CheckStyle](http://checkstyle.sourceforge.net/) with [Google's Java Style Guide](http://checkstyle.sourceforge.net/reports/google-java-style.html).
143
143
144
-
145
-
## Creating a Pull Request<aname="creating_a_pull_request"></a>
144
+
<aname="creating-a-pull-request"></a>
145
+
## Creating a Pull Request
146
146
147
147
1.[Fork](https://help.github.com/fork-a-repo/) the project, clone your fork,
148
148
and configure the remotes:
@@ -151,7 +151,7 @@ Please run your code through:
151
151
# Clone your fork of the repo into the current directory
0 commit comments