Starting with Chrome 33, certain types of input elements do not

support the selection API (in fact, they throw when you try to
access the property). This prevents us from fully simulating typing
in the atoms.

Try to case these cases and throw a more descriptive error, pointing
the user at https://code.google.com/p/chromium/issues/detail?id=330456
so they have the proper context for why typing no longer works as
expected.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=60184506

Author: sevaseva

javascript/atoms/keyboard.js

@@ -603,8 +603,12 @@ bot.Keyboard.prototype.updateOnCharacter_ = function(key) {
 
   var character = this.getChar_(key);
   var newPos = goog.dom.selection.getStart(this.getElement()) + 1;
-  goog.dom.selection.setText(this.getElement(), character);
-  goog.dom.selection.setStart(this.getElement(), newPos);
+  if (bot.Keyboard.supportsSelection(this.getElement())) {
+    goog.dom.selection.setText(this.getElement(), character);
+    goog.dom.selection.setStart(this.getElement(), newPos);
+  } else {
+    this.getElement().value += character;
+  }
   if (goog.userAgent.WEBKIT) {
     this.fireHtmlEvent(bot.events.EventType.TEXTINPUT);
   }
@@ -629,8 +633,12 @@ bot.Keyboard.prototype.updateOnEnter_ = function() {
   if (bot.dom.isElement(this.getElement(), goog.dom.TagName.TEXTAREA)) {
     var newPos = goog.dom.selection.getStart(this.getElement()) +
         bot.Keyboard.NEW_LINE_.length;
-    goog.dom.selection.setText(this.getElement(), bot.Keyboard.NEW_LINE_);
-    goog.dom.selection.setStart(this.getElement(), newPos);
+    if (bot.Keyboard.supportsSelection(this.getElement())) {
+      goog.dom.selection.setText(this.getElement(), bot.Keyboard.NEW_LINE_);
+      goog.dom.selection.setStart(this.getElement(), newPos);
+    } else {
+      this.getElement().value += bot.Keyboard.NEW_LINE_;
+    }
     if (!goog.userAgent.IE) {
       this.fireHtmlEvent(bot.events.EventType.INPUT);
     }
@@ -650,6 +658,7 @@ bot.Keyboard.prototype.updateOnBackspaceOrDelete_ = function(key) {
 
   // Determine what should be deleted.  If text is already selected, that
   // text is deleted, else we move left/right from the current cursor.
+  bot.Keyboard.checkCanUpdateSelection_(this.getElement());
   var endpoints = goog.dom.selection.getEndPoints(this.getElement());
   if (endpoints[0] == endpoints[1]) {
     if (key == bot.Keyboard.Keys.BACKSPACE) {
@@ -692,6 +701,7 @@ bot.Keyboard.prototype.updateOnBackspaceOrDelete_ = function(key) {
  * @private
  */
 bot.Keyboard.prototype.updateOnLeftOrRight_ = function(key) {
+  bot.Keyboard.checkCanUpdateSelection_(this.getElement());
   var element = this.getElement();
   var start = goog.dom.selection.getStart(element);
   var end = goog.dom.selection.getEnd(element);
@@ -758,6 +768,7 @@ bot.Keyboard.prototype.updateOnLeftOrRight_ = function(key) {
  * @private
  */
 bot.Keyboard.prototype.updateOnHomeOrEnd_ = function(key) {
+  bot.Keyboard.checkCanUpdateSelection_(this.getElement());
   var element = this.getElement();
   var start = goog.dom.selection.getStart(element);
   var end = goog.dom.selection.getEnd(element);
@@ -792,6 +803,47 @@ bot.Keyboard.prototype.updateOnHomeOrEnd_ = function(key) {
 };
 
 
+/**
+ * Checks that the cursor position can be updated for the given element.
+ * @param {!Element} element The element to test.
+ * @throws {Error} If the cursor position cannot be updated for the given
+ *     element.
+ * @see https://code.google.com/p/chromium/issues/detail?id=330456
+ * @private
+ */
+bot.Keyboard.checkCanUpdateSelection_ = function(element) {
+  try {
+    /** @suppress {suspiciousCode} */
+    element.selectionStart;
+  } catch (ex) {
+    // The native error message is actually pretty informative, just add a
+    // reference to the relevant Chrome bug to provide more context.
+    if (ex.message.indexOf('does not support selection.') != -1) {
+      // message is a readonly property, so need to rethrow.
+      throw Error(ex.message + ' (For more information, see ' +
+          'https://code.google.com/p/chromium/issues/detail?id=330456)');
+    }
+    throw ex;
+  }
+};
+
+
+/**
+ * @param {!Element} element The element to test.
+ * @return {boolean} Whether the given element supports the input element
+ *     selection API.
+ * @see https://code.google.com/p/chromium/issues/detail?id=330456
+ */
+bot.Keyboard.supportsSelection = function(element) {
+  try {
+    bot.Keyboard.checkCanUpdateSelection_(element);
+  } catch (ex) {
+    return false;
+  }
+  return true;
+};
+
+
 /**
 * @param {number} pos New position of the cursor.
 * @private

javascript/atoms/test/type_test.html

@@ -4,7 +4,7 @@
   <title>type_test</title>
   <script src="test_bootstrap.js"></script>
   <script type="text/javascript">
-    goog.require('bot.Keyboard.Keys');
+    goog.require('bot.Keyboard');
     goog.require('bot.action');
     goog.require('bot.events');
     goog.require('bot.userAgent');
@@ -28,6 +28,20 @@
 
     var INPUT_IDS = ['textbox', 'password', 'email', 'search', 'textarea'];
 
+    // Keys that impact the cursor's position and require the selection API.
+    var SELECTION_KEYS = [
+      bot.Keyboard.Keys.BACKSPACE,
+      bot.Keyboard.Keys.DELETE,
+      bot.Keyboard.Keys.PAGE_UP,
+      bot.Keyboard.Keys.PAGE_DOWN,
+      bot.Keyboard.Keys.END,
+      bot.Keyboard.Keys.HOME,
+      bot.Keyboard.Keys.LEFT,
+      bot.Keyboard.Keys.UP,
+      bot.Keyboard.Keys.RIGHT,
+      bot.Keyboard.Keys.DOWN,
+    ];
+
     var ALT = bot.Keyboard.Keys.ALT;
     var BACKSPACE = bot.Keyboard.Keys.BACKSPACE;
     var CONTROL = bot.Keyboard.Keys.CONTROL;
@@ -83,7 +97,7 @@
      * have the correct values afterwards.  textbox_count should display the
      * number of times textbox's oninput (non IE) or onpropertychange (IE) event
      * fired.
-     * @param {string|bot.Keyboard.Key|Array.<string, bot.Keyboard.Key>}
+     * @param {string|bot.Keyboard.Key|Array.<(string|bot.Keyboard.Key)>}
      *   input Value to type into textbox.
      * @param {string=} opt_finalValue The final value that should appear in
      *   the input.  Defaults to input.
@@ -111,8 +125,23 @@
           goog.isDef(opt_textInputCount) ? opt_textInputCount : inputCount;
       var initValue = opt_initValue || '';
 
+      // Determine if our test requires updating the cursor position, which is
+      // not supported in all scenarios.
+      var needsSelection = function(input) {
+        if (goog.isArray(input)) {
+          return goog.array.some(input, needsSelection);
+        }
+        return goog.array.contains(SELECTION_KEYS, input);
+      }
+      var requiresSelection = goog.array.some(input, needsSelection);
+
       for (var i = 0; i < inputIds.length; i++) {
         var inputBox = document.getElementById(inputIds[i]);
+        if (requiresSelection && !bot.Keyboard.supportsSelection(inputBox)) {
+          // Test requires selection, but the current element will throw when
+          // accessing those properties, so skip this case.
+          continue;
+        }
         inputBox.value = initValue;
         inputCountBox.value = '0';
         textInputCountBox.value = '0';