0.54:

    - replaced the remaining eval calls by JSON.parse, for safety and improved parsing performance
    - adjusted the application list autocomplete so it shows the full list of applications when the config field is cleared
    - minor variable name change
    - no new features

Author: Romain GUINOT

README.md

@@ -174,6 +174,13 @@ Some sample screenshots with different configurations are included below :
 Changelog
 ---------
 
+0.54:
+
+    - replaced the remaining eval calls by JSON.parse, for safety and improved parsing performance
+    - adjusted the application list autocomplete so it shows the full list of applications when the config field is cleared
+    - minor variable name change
+    - no new features
+
 0.53:
 
     - updated README to mention that the Alfresco repository restricts access to audit data to repository administrators only. Only admins will therefore be able to use the dashlet.

build.properties

@@ -1,3 +1,3 @@
-build.version=0.53
+build.version=0.54
 project.name=audit-dashlet
 jar.name=${project.name}-${build.version}.jar

config/alfresco/site-webscripts/org/sharextras/components/dashlets/audit-application-data.get.js

@@ -81,7 +81,7 @@ function main()
          var escaped_response = json_requoted_response.replace(/(\n|\r\n|\r)/g, " ");
          //if (logger.isLoggingEnabled()) logger.log("escaped_response:\n"+escaped_response);
 
-         var auditresponse = eval("(" + escaped_response + ")");
+         var auditresponse = JSON.parse(escaped_response);
          model.auditresponse = auditresponse;
          model.jsonResp = result.response;
       }
@@ -105,7 +105,7 @@ function isJsonQuoteFixRequired(connector)
 {
    // get current server version to determine if a workaround for ALF-8307 is needed.
    var srvInfo = connector.get("/api/server");
-   var srvInfoJson = eval('(' + srvInfo + ')');
+   var srvInfoJson = JSON.parse(srvInfo);
 
    var serverVersion, serverEdition, serverVersionNumbers;
 

config/alfresco/site-webscripts/org/sharextras/components/dashlets/audit-application.get.js

@@ -2,18 +2,18 @@ function getUserIsSiteManager(username)
 {
    // Call the repository to see if the user is a site manager or not
    var userIsSiteManager = false;
-   var obj = context.properties["memberships"];
-   if (!obj)
+   var membership = context.properties["memberships"];
+   if (!membership)
    {
       var json = remote.call("/api/sites/" + page.url.templateArgs.site + "/memberships/" + stringUtils.urlEncode(username));
       if (json.status == 200)
       {
-         obj = eval('(' + json + ')');
+         membership = JSON.parse(json);
       }
    }
-   if (obj)
+   if (membership)
    {
-      userIsSiteManager = (obj.role == "SiteManager");
+      userIsSiteManager = (membership.role == "SiteManager");
    }
    return userIsSiteManager;
 }

config/alfresco/site-webscripts/org/sharextras/modules/dashlets/audit-application-applist.get.js

@@ -9,7 +9,7 @@ function main()
 
    if (result.status == status.STATUS_OK)
    {
-      var auditcontrol = eval("(" + result.response + ")");
+      var auditcontrol = JSON.parse(result.response);
       model.auditcontrol = auditcontrol;
    }
    else

source/web/extras/components/dashlets/audit-application.js

@@ -1259,6 +1259,8 @@ if (typeof Extras.dashlet == "undefined" || !Extras.dashlet)
                      appAutoComplete.queryMatchContains = true;
                      appAutoComplete.formatResult = formatResult;
                      appAutoComplete.itemSelectEvent.subscribe(appHandler);
+                     appAutoComplete.minQueryLength = 0; // 0 so that it shows the full list of applications when the config field is cleared. 
+                                                         // The application list should be quite small so 0-length query here should be OK.
 
                      // if no app is currently configured, preload the list to display all entries immediately on config popup
                      // the leading space has been intentionnally added by audit-application-applist.get.json.ftl