Skip to content

Commit 025f7f9

Browse files
Merge pull request ryanmcdermott#222 from filipetedim/patch-1
Fixed duplicate code
2 parents 6e7b67b + e12f62f commit 025f7f9

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

README.md

+7-9
Original file line numberDiff line numberDiff line change
@@ -439,23 +439,21 @@ function showEmployeeList(employees) {
439439
employees.forEach((employee) => {
440440
const expectedSalary = employee.calculateExpectedSalary();
441441
const experience = employee.getExperience();
442+
443+
let data = {
444+
expectedSalary,
445+
experience
446+
};
442447

443-
let portfolio;
444448
switch (employee.type) {
445449
case 'manager':
446-
portfolio = employee.getMBAProjects();
450+
data.portfolio = employee.getMBAProjects();
447451
break;
448452
case 'developer':
449-
portfolio = employee.getGithubLink();
453+
data.githubLink = employee.getGithubLink();
450454
break;
451455
}
452456

453-
const data = {
454-
expectedSalary,
455-
experience,
456-
portfolio
457-
};
458-
459457
render(data);
460458
});
461459
}

0 commit comments

Comments
 (0)