Merge pull request rmosolgo#2343 from daemonsy/to_json_circular_reference

Implement #to_hash so input objects can be serialized/splatted

Author: rmosolgo

lib/graphql/schema/input_object.rb

@@ -53,6 +53,10 @@ def to_h
         end
       end
 
+      def to_hash
+        to_h
+      end
+
       def unwrap_value(value)
         case value
         when Array

spec/graphql/schema/input_object_spec.rb

@@ -277,7 +277,7 @@ def self.resolve_type(type, obj, ctx)
     end
   end
 
-  describe "#to_h" do
+  describe 'hash conversion behavior' do
     module InputObjectToHTest
       class TestInput1 < GraphQL::Schema::InputObject
         graphql_name "TestInput1"
@@ -297,16 +297,26 @@ class TestInput2 < GraphQL::Schema::InputObject
       TestInput2.to_graphql
     end
 
-    it "returns a symbolized, aliased, ruby keyword style hash" do
+    before do
       arg_values = {a: 1, b: 2, c: { d: 3, e: 4, instrumentId: "Instrument/Drum Kit"}}
 
-      input_object = InputObjectToHTest::TestInput2.new(
+      @input_object = InputObjectToHTest::TestInput2.new(
         arg_values,
         context: OpenStruct.new(schema: Jazz::Schema),
         defaults_used: Set.new
       )
+    end
 
-      assert_equal({ a: 1, b: 2, input_object: { d: 3, e: 4, instrument: Jazz::Models::Instrument.new("Drum Kit", "PERCUSSION") } }, input_object.to_h)
+    describe "#to_h" do
+      it "returns a symbolized, aliased, ruby keyword style hash" do
+        assert_equal({ a: 1, b: 2, input_object: { d: 3, e: 4, instrument: Jazz::Models::Instrument.new("Drum Kit", "PERCUSSION") } }, @input_object.to_h)
+      end
+    end
+
+    describe "#to_hash" do
+      it "returns the same results as #to_h (aliased)" do
+        assert_equal(@input_object.to_h, @input_object.to_hash)
+      end
     end
   end
 

spec/integration/rails/graphql/input_object_spec.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+describe GraphQL::Schema::InputObject do
+  let(:input_object) do
+    Dummy::DairyProductInput.new(
+      { source: 'COW',  fatContent: 0.8 },
+      defaults_used: Set.new,
+      context: GraphQL::Query::NullContext)
+  end
+
+  describe '#to_json' do
+    it 'returns JSON serialized representation of the variables hash' do
+      # Regression note: Previously, calling `to_json` on input objects caused stack too deep errors
+      assert_equal input_object.to_json, { source: "COW", fat_content: 0.8 }.to_json
+    end
+  end
+end
+