Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sohobloo/react-native-modal-dropdown
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: siemiatj/react-native-modal-dropdown-legacy
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 16 commits
  • 4 files changed
  • 7 contributors

Commits on Mar 26, 2020

  1. bump version deprecated-react-native-listview to 0.0.6; version 0.0.5… 

    … doesnt work with [email protected]
    irekrog committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    ed657b3 View commit details
    Browse the repository at this point in the history

  2. bump version from 0.7.0 to 0.7.1

    irekrog committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    08c262b View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2020

  1. Update ModalDropdown.js 

    The top value is not valid value which is return is NAN.
Error:
Invariant Violation: [757,"RCTView",91,{"position":"absolute","height":"auto","borderWidth":1,"borderColor":4291022286,"borderRadius":2,"backgroundColor":4294967295,"justifyContent":"center","borderTopWidth":0,"width":372.6,"marginTop":17.92,"shadowColor":4278190080,"shadowOffset":{"width":0,"height":2},"shadowOpacity":0.25,"shadowRadius":3.84,"elevation":5,"top":"<<NaN>>","left":33}] is not usable as a native method argument
    @noumansakhawat-dev @siemiatj
    noumansakhawat-dev authored and siemiatj committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    ccf2705 View commit details
    Browse the repository at this point in the history

  2. - bump version to 0.7.2

    @siemiatj
    siemiatj committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    45c44f6 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1 from siemiatj/patch-1 

    Fix top value NaN position
    @siemiatj
    siemiatj authored Apr 15, 2020
    Configuration menu
    Copy the full SHA
    9cb828d View commit details
    Browse the repository at this point in the history

  4. feature(modal) add select multiple select.

    @siemiatj
    ProSolvo authored and siemiatj committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    5dadf5e View commit details
    Browse the repository at this point in the history

  5. - bump version

    @siemiatj
    siemiatj committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    f9c3892 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #2 from siemiatj/feature/multipleselect 

    [Feature] multi-select
    @siemiatj
    siemiatj authored Apr 15, 2020
    Configuration menu
    Copy the full SHA
    a4f0813 View commit details
    Browse the repository at this point in the history

  7. Use getDerivedStateFromProps instead of componentWillReceiveProps 

    Changed lifecycle functions according to changes in React.
    @miksa @siemiatj
    miksa authored and siemiatj committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    9d3dff2 View commit details
    Browse the repository at this point in the history

  8. - bump version

    @siemiatj
    siemiatj committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    3b2c085 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #3 from siemiatj/derived-state 

    Derived state
    @siemiatj
    siemiatj authored Apr 15, 2020
    Configuration menu
    Copy the full SHA
    845d840 View commit details
    Browse the repository at this point in the history

  10. update ListView to Flatlist

    @marshallshen @siemiatj
    marshallshen authored and siemiatj committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    731e3c2 View commit details
    Browse the repository at this point in the history

  11. - bump version

    @siemiatj
    siemiatj committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    5cf84c4 View commit details
    Browse the repository at this point in the history

  12. Merge pull request #4 from siemiatj/flatlist 

    Flatlist
    @siemiatj
    siemiatj authored Apr 15, 2020
    Configuration menu
    Copy the full SHA
    630b8c3 View commit details
    Browse the repository at this point in the history

  13. - remove dependency on listview

    @siemiatj
    siemiatj committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    654327b View commit details
    Browse the repository at this point in the history

  14. fix package.json

    @siemiatj
    siemiatj committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    9ea6efc View commit details
    Browse the repository at this point in the history
Loading