Merge pull request OpenRA#12891 from pchote/register-mods-first-time

Add the current mod to the external mods database on launch.

Author: abcdefg30

OpenRA.Game/ExternalMods.cs

@@ -16,6 +16,7 @@
 using System.IO;
 using System.Linq;
 using OpenRA.Graphics;
+using OpenRA.Primitives;
 
 namespace OpenRA
 {
@@ -35,7 +36,7 @@ public class ExternalMod
 
 	public class ExternalMods : IReadOnlyDictionary<string, ExternalMod>
 	{
-		readonly Dictionary<string, ExternalMod> mods;
+		readonly Dictionary<string, ExternalMod> mods = new Dictionary<string, ExternalMod>();
 		readonly SheetBuilder sheetBuilder;
 		readonly string launchPath;
 
@@ -47,40 +48,39 @@ public ExternalMods(string launchPath)
 
 			this.launchPath = launchPath;
 			sheetBuilder = new SheetBuilder(SheetType.BGRA, 256);
-			mods = LoadMods();
-		}
 
-		Dictionary<string, ExternalMod> LoadMods()
-		{
-			var ret = new Dictionary<string, ExternalMod>();
+			// Load registered mods
 			var supportPath = Platform.ResolvePath(Path.Combine("^", "ModMetadata"));
 			if (!Directory.Exists(supportPath))
-				return ret;
+				return;
 
 			foreach (var path in Directory.GetFiles(supportPath, "*.yaml"))
 			{
 				try
 				{
 					var yaml = MiniYaml.FromStream(File.OpenRead(path), path).First().Value;
-					var mod = FieldLoader.Load<ExternalMod>(yaml);
-					var iconNode = yaml.Nodes.FirstOrDefault(n => n.Key == "Icon");
-					if (iconNode != null && !string.IsNullOrEmpty(iconNode.Value.Value))
-					{
-						using (var stream = new MemoryStream(Convert.FromBase64String(iconNode.Value.Value)))
-						using (var bitmap = new Bitmap(stream))
-							mod.Icon = sheetBuilder.Add(bitmap);
-					}
-
-					ret.Add(ExternalMod.MakeKey(mod), mod);
+					LoadMod(yaml);
 				}
 				catch (Exception e)
 				{
 					Log.Write("debug", "Failed to parse mod metadata file '{0}'", path);
 					Log.Write("debug", e.ToString());
 				}
 			}
+		}
+
+		void LoadMod(MiniYaml yaml)
+		{
+			var mod = FieldLoader.Load<ExternalMod>(yaml);
+			var iconNode = yaml.Nodes.FirstOrDefault(n => n.Key == "Icon");
+			if (iconNode != null && !string.IsNullOrEmpty(iconNode.Value.Value))
+			{
+				using (var stream = new MemoryStream(Convert.FromBase64String(iconNode.Value.Value)))
+				using (var bitmap = new Bitmap(stream))
+					mod.Icon = sheetBuilder.Add(bitmap);
+			}
 
-			return ret;
+			mods.Add(ExternalMod.MakeKey(mod), mod);
 		}
 
 		internal void Register(Manifest mod)
@@ -108,9 +108,20 @@ internal void Register(Manifest mod)
 			};
 
 			var supportPath = Platform.ResolvePath(Path.Combine("^", "ModMetadata"));
-			Directory.CreateDirectory(supportPath);
 
-			File.WriteAllLines(Path.Combine(supportPath, key + ".yaml"), yaml.ToLines(false).ToArray());
+			try
+			{
+				// Make sure the mod is available for this session, even if saving it fails
+				LoadMod(yaml.First().Value);
+
+				Directory.CreateDirectory(supportPath);
+				File.WriteAllLines(Path.Combine(supportPath, key + ".yaml"), yaml.ToLines(false).ToArray());
+			}
+			catch (Exception e)
+			{
+				Log.Write("debug", "Failed to register currrent mod metadata");
+				Log.Write("debug", e.ToString());
+			}
 
 			// Clean up stale mod registrations:
 			//  - LaunchPath no longer exists (uninstalled)