Skip to content

Commit 2ff45b1

Browse files
committed
Issue ESAPI#376 Added URL with ports, and added logic to prevent an invalid port from being used.
1 parent aafa353 commit 2ff45b1

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

src/main/java/org/owasp/esapi/reference/DefaultValidator.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1331,6 +1331,12 @@ public String getCanonicalizedURI(URI dirtyUri) throws IntrusionException{
13311331
logger.debug(Logger.EVENT_FAILURE, "decoding error when parsing [" + dirtyUri.toString() + "]");
13321332
}
13331333
}
1334+
//Check if the port is -1, if it is, omit it from the output.
1335+
if(seg == UriSegment.PORT){
1336+
if("-1" == parseMap.get(seg)){
1337+
value = "";
1338+
}
1339+
}
13341340
parseMap.put(seg, value );
13351341
}
13361342

src/test/resources/urisForTest.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
https://127.0.0.1:8080/foo/bar,TRUE
2+
http://shareasale.com:8080/sem/fusce.xml?sed=sodales&tristique=scelerisque,TRUE
13
http://shareasale.com/sem/fusce.xml?sed=sodales&tristique=scelerisque,TRUE
24
http://core-jenkins.scansafe.cisco.com/佐贺诺伦-^ńörén.jpg,FALSE
35
https://wunderground.com/luctus/rutrum/nulla/tellus/in/sagittis.xml?et=vulputate&magnis=ut&dis=ultrices&parturient=vel&montes=augue&nascetur=vestibulum&ridiculus=ante&mus=ipsum&vivamus=primis&vestibulum=in&sagittis=faucibus&sapien=orci&cum=luctus&sociis=et&natoque=ultrices&penatibus=posuere&et=cubilia&magnis=curae&dis=donec&parturient=pharetra&montes=magna&nascetur=vestibulum&ridiculus=aliquet&mus=ultrices&etiam=erat&vel=tortor&augue=sollicitudin&vestibulum=mi&rutrum=sit&rutrum=amet&neque=lobortis&aenean=sapien&auctor=sapien&gravida=non&sem=mi&praesent=integer&id=ac&massa=neque&id=duis&nisl=bibendum&venenatis=morbi&lacinia=non&aenean=quam&sit=nec&amet=dui&justo=luctus&morbi=rutrum&ut=nulla&odio=tellus&cras=in&mi=sagittis&pede=dui&malesuada=vel&in=nisl&imperdiet=duis&et=ac&commodo=nibh&vulputate=fusce&justo=lacus&in=purus&blandit=aliquet&ultrices=at&enim=feugiat&lorem=non&ipsum=pretium&dolor=quis&sit=lectus,TRUE

0 commit comments

Comments
 (0)