[ptmt#18] Add padding prop to TextInput multiline={true}

Author: ptmt

Libraries/Text/RCTTextView.m

@@ -34,6 +34,7 @@ @implementation RCTTextView
   NSString *_placeholder;
   TextViewWithPlaceHolder *_textView;
   NSInteger _nativeEventCount;
+  CGFloat _padding;
 }
 
 - (instancetype)initWithEventDispatcher:(RCTEventDispatcher *)eventDispatcher
@@ -49,6 +50,7 @@ - (instancetype)initWithEventDispatcher:(RCTEventDispatcher *)eventDispatcher
     //_textView.scrollsToTop = NO;
     _jsRequestingFirstResponder = YES;
     _textView.delegate = self;
+    _padding = 0;
     [self addSubview:_textView];
   }
   return self;
@@ -66,22 +68,24 @@ - (void)updateFrames
   // We apply the left inset to the frame since a negative left text-container
   // inset mysteriously causes the text to be hidden until the text view is
   // first focused.
-  NSEdgeInsets adjustedFrameInset = NSEdgeInsetsZero;
-  adjustedFrameInset.left = _contentInset.left - 5;
-  
-  NSEdgeInsets adjustedTextContainerInset = _contentInset;
-  adjustedTextContainerInset.top += 5;
-  adjustedTextContainerInset.left = 0;
-  
+//  NSEdgeInsets adjustedFrameInset = NSEdgeInsetsZero;
+//  adjustedFrameInset.left = _contentInset.left - 5;
+//  
+//  NSEdgeInsets adjustedTextContainerInset = _contentInset;
+//  adjustedTextContainerInset.top += 5;
+//  adjustedTextContainerInset.left = 0;
+//  
   CGRect frame = self.frame;// TODO: UIEdgeInsetsInsetRect(self.bounds, adjustedFrameInset);
   _textView.frame = frame;
 
   // TODO:
- // _textView.textContainerInset = adjustedTextContainerInset;
- // _placeholderView.textContainerInset = adjustedTextContainerInset;
+  [_textView setTextContainerInset:CGSizeMake(_padding, _padding)];
+  //_textView.textContainerInset = adjustedTextContainerInset;
+
 }
 
 
+
 - (void)updatePlaceholder
 {
   if (_placeholder) {
@@ -132,6 +136,13 @@ - (void)setPlaceholderTextColor:(NSColor *)placeholderTextColor
   [self updatePlaceholder];
 }
 
+- (void)setPadding:(CGFloat )padding
+{
+ // NSLog(@"padding %@", padding);
+  _padding = padding;
+  [self updateFrames];
+}
+
 - (void)setContentInset:(NSEdgeInsets)contentInset
 {
   _contentInset = contentInset;

Libraries/Text/RCTTextViewManager.m

@@ -28,6 +28,7 @@ - (NSView *)view
 RCT_REMAP_VIEW_PROPERTY(editable, textView.editable, BOOL)
 RCT_EXPORT_VIEW_PROPERTY(placeholder, NSString)
 RCT_EXPORT_VIEW_PROPERTY(placeholderTextColor, NSColor)
+RCT_EXPORT_VIEW_PROPERTY(padding, CGFloat)
 RCT_EXPORT_VIEW_PROPERTY(text, NSString)
 RCT_EXPORT_VIEW_PROPERTY(maxLength, NSNumber)
 RCT_EXPORT_VIEW_PROPERTY(clearTextOnFocus, BOOL)