Skip to content

security: Hide token by default, add show link/button to expose #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ElijahLynn opened this issue Mar 11, 2025 · 3 comments
Closed

security: Hide token by default, add show link/button to expose #306

ElijahLynn opened this issue Mar 11, 2025 · 3 comments

Comments

@ElijahLynn
Copy link

Was just on a screenshare showing my team my settings and it exposed most of my token.

I propose that we hide the token by default, and add a show link or button to expose when needed.

Image

@notlmn
Copy link
Collaborator

notlmn commented Jun 1, 2025

I can't find the issue where this was originally discussed but the idea was for this to not give a false sense of security where we store the token in a secure way (hash and salted or something similar for storing secrets).

Anyone that has access to the machine can retrieve the token from browsers storage easily. The input type used here reflects that behavior and instead makes the token input wide enough to not display the entire token in a single go.

@notlmn
Copy link
Collaborator

notlmn commented Jun 1, 2025

Found that the discussion was in a different (but related) repo - refined-github/refined-github#1374 (comment)

@notlmn notlmn closed this as completed Jun 1, 2025
@ElijahLynn
Copy link
Author

Okay, but exposing it accidentally, even partially, on a screenshare is not good. The availability of a "show" button would accomplish that goal. I see that was discussed and I think this should be revisited, and reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants