Merge pull request #39 from B-CDD/chore/remove-singleton-stdlib

Remove usage of singleton (stdlib)

Author: serradura

Steepfile

@@ -10,7 +10,7 @@ target :lib do
   # check 'app/models/**/*.rb'        # Glob
   # ignore 'lib/templates/*.rb'
 
-  library 'singleton'                 # Standard libraries
+  # library 'singleton'               # Standard libraries
   # library 'strong_json'             # Gems
 
   # configure_code_diagnostics(D::Ruby.default)      # `default` diagnostics setting (applies by default)

lib/bcdd/result.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'set'
-require 'singleton'
 
 module BCDD
   require_relative 'success'

lib/bcdd/result/config.rb

@@ -9,8 +9,6 @@
 
 class BCDD::Result
   class Config
-    include ::Singleton
-
     attr_reader :addon, :feature, :constant_alias, :pattern_matching
 
     def initialize
@@ -58,5 +56,9 @@ def inspect
         "options=#{options.keys.sort.inspect} " \
         "and_then!=#{and_then!.options.inspect}>"
     end
+
+    @instance = new
+
+    singleton_class.send(:attr_reader, :instance)
   end
 end

lib/bcdd/result/transitions/config.rb

@@ -2,8 +2,6 @@
 
 module BCDD::Result::Transitions
   class Config
-    include ::Singleton
-
     attr_reader :listener, :trace_id
 
     def initialize
@@ -22,5 +20,9 @@ def trace_id=(arg)
 
       @trace_id = arg
     end
+
+    @instance = new
+
+    singleton_class.send(:attr_reader, :instance)
   end
 end

sig/bcdd/result/config.rbs

@@ -1,6 +1,4 @@
 class BCDD::Result::Config
-  include Singleton
-
   ADDON: Hash[Symbol, Hash[Symbol, untyped]]
   FEATURE: Hash[Symbol, Hash[Symbol, untyped]]
   PATTERN_MATCHING: Hash[Symbol, Hash[Symbol, untyped]]

sig/bcdd/result/transitions.rbs

@@ -64,8 +64,6 @@ class BCDD::Result
     end
 
     class Config
-      include ::Singleton
-
       attr_reader listener: untyped
       attr_reader trace_id: ::Proc
 

test/bcdd/result/config_test.rb

@@ -5,7 +5,7 @@
 class BCDD::Result::Config
   class Test < Minitest::Test
     test '.instance' do
-      assert BCDD::Result::Config.instance.is_a?(Singleton)
+      assert BCDD::Result::Config.instance.is_a?(BCDD::Result::Config)
 
       assert_same(BCDD::Result::Config.instance, BCDD::Result.config)
     end