Skip to content

Enhancement: Update PDDF PSU Drivers to make data formats configurable. #22822

Open
sonic-net/SONiC
#2002
@michaelc-nexthop

Description

@michaelc-nexthop

Is it platform specific

generic

Importance or Severity

Critical

Description of the enhancement

Update the PDDF PSU Drivers to support additional data formats beyond the default formatting of Linear11. Like other PDDF based drivers, these attributes should be configurable through sysfs as it is done for other PDDF based drivers.

Current Behavior

Currently, all the formatting for PDDF PSU drivers are defaulted to Linear11. This leads to incorrect voltage/current/power reporting numbers. Example:

admin@ge108:~$ show plat psustatus
PSU    Model                Serial      HW Rev      Voltage (V)    Current (A)    Power (W)  Status    LED
-----  -------------------  ----------  --------  -------------  -------------  -----------  --------  -----
PSU 1  D1U74T-W-3200-12-HB  M42448RAC0  N/A             1096.00          25.19       310.00  OK        green
PSU 2  D1U74T-W-3200-12-HB  M42448RAC0  N/A             1152.00          25.09       308.50  OK        green

voltage is reported as 1096, but when you divide power and current, you will see the expected voltage is 12.3V

Proposed Behavior

Add a "data_format" attribute to the PSU PDDF driver that allows the correct data format to be passed in via userspace and then do the proper calculations

admin@sonic:~$ show plat psustatus
PSU    Model                Serial      HW Rev      Voltage (V)    Current (A)    Power (W)  Status    LED
-----  -------------------  ----------  --------  -------------  -------------  -----------  --------  -----
PSU 1  D1U74T-W-3200-12-HB  M42448RAC0  N/A               12.20         134.50      1644.00  OK        green

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions