Compile error in example CustomChars, used print(x, BYTE) that is not deprecated in Arduino 1.0.

Refactored the initialization of the library, unneeded init functions are removed.
Removed double member field _numlines (already has _rows).

Author: fdebrabander

LiquidCrystal_I2C.cpp

@@ -22,33 +22,25 @@
 // can't assume that its in that state when a sketch starts (and the
 // LiquidCrystal constructor is called).
 
-LiquidCrystal_I2C::LiquidCrystal_I2C(uint8_t lcd_addr,uint8_t lcd_cols,uint8_t lcd_rows)
+LiquidCrystal_I2C::LiquidCrystal_I2C(uint8_t lcd_addr, uint8_t lcd_cols, uint8_t lcd_rows, uint8_t dotsize)
 {
 	_addr = lcd_addr;
 	_cols = lcd_cols;
 	_rows = lcd_rows;
+	_dotsize = dotsize;
 	_backlightval = LCD_NOBACKLIGHT;
 }
 
-void LiquidCrystal_I2C::init(){
-	init_priv();
-}
-
-void LiquidCrystal_I2C::init_priv()
-{
+void LiquidCrystal_I2C::begin() {
 	Wire.begin();
 	_displayfunction = LCD_4BITMODE | LCD_1LINE | LCD_5x8DOTS;
-	begin(_cols, _rows);  
-}
 
-void LiquidCrystal_I2C::begin(uint8_t cols, uint8_t lines, uint8_t dotsize) {
-	if (lines > 1) {
+	if (_rows > 1) {
 		_displayfunction |= LCD_2LINE;
 	}
-	_numlines = lines;
 
 	// for some 1 line displays you can select a 10 pixel high font
-	if ((dotsize != 0) && (lines == 1)) {
+	if ((_dotsize != 0) && (_rows == 1)) {
 		_displayfunction |= LCD_5x10DOTS;
 	}
 
@@ -112,8 +104,8 @@ void LiquidCrystal_I2C::home(){
 
 void LiquidCrystal_I2C::setCursor(uint8_t col, uint8_t row){
 	int row_offsets[] = { 0x00, 0x40, 0x14, 0x54 };
-	if (row > _numlines) {
-		row = _numlines-1;    // we count rows starting w/0
+	if (row > _rows) {
+		row = _rows-1;    // we count rows starting w/0
 	}
 	command(LCD_SETDDRAMADDR | (col + row_offsets[row]));
 }

LiquidCrystal_I2C.h

@@ -53,8 +53,8 @@
 
 class LiquidCrystal_I2C : public Print {
 public:
-	LiquidCrystal_I2C(uint8_t lcd_addr,uint8_t lcd_cols,uint8_t lcd_rows);
-	void begin(uint8_t cols, uint8_t rows, uint8_t charsize = LCD_5x8DOTS );
+	LiquidCrystal_I2C(uint8_t lcd_addr,uint8_t lcd_cols,uint8_t lcd_rows, uint8_t charsize = LCD_5x8DOTS);
+	void begin();
 	void clear();
 	void home();
 	void noDisplay();
@@ -79,7 +79,6 @@ class LiquidCrystal_I2C : public Print {
 	void setCursor(uint8_t, uint8_t); 
 	virtual size_t write(uint8_t);
 	void command(uint8_t);
-	void init();
 
 	inline void blink_on() { blink(); }
 	inline void blink_off() { noBlink(); }
@@ -103,7 +102,6 @@ class LiquidCrystal_I2C : public Print {
 	void draw_vertical_graph(uint8_t row, uint8_t column, uint8_t len,  uint8_t pixel_col_end);
 
 private:
-	void init_priv();
 	void send(uint8_t, uint8_t);
 	void write4bits(uint8_t);
 	void expanderWrite(uint8_t);
@@ -112,9 +110,9 @@ class LiquidCrystal_I2C : public Print {
 	uint8_t _displayfunction;
 	uint8_t _displaycontrol;
 	uint8_t _displaymode;
-	uint8_t _numlines;
 	uint8_t _cols;
 	uint8_t _rows;
+	uint8_t _dotsize;
 	uint8_t _backlightval;
 };
 

examples/CustomChars/CustomChars.ino

@@ -15,7 +15,7 @@ LiquidCrystal_I2C lcd(0x27, 16, 2);
 
 void setup()
 {
-	lcd.init();
+	lcd.begin();
 	lcd.backlight();
 
 	lcd.createChar(0, bell);
@@ -31,7 +31,7 @@ void setup()
 	lcd.print("Hello world...");
 	lcd.setCursor(0, 1);
 	lcd.print(" i ");
-	lcd.print(3, BYTE);
+	lcd.write(3);
 	lcd.print(" arduinos!");
 	delay(5000);
 	displayKeyCodes();
@@ -50,7 +50,7 @@ void displayKeyCodes(void) {
 		lcd.setCursor(0, 1);
 
 		for (int j = 0; j < 16; j++) {
-			lcd.print(i + j, BYTE);
+			lcd.write(i + j);
 		}
 		i += 16;
 

examples/HelloWorld/HelloWorld.ino

@@ -7,7 +7,7 @@ LiquidCrystal_I2C lcd(0x27, 16, 2);
 void setup()
 {
 	// initialize the LCD
-	lcd.init();
+	lcd.begin();
 
 	// Turn on the blacklight and print a message.
 	lcd.backlight();

examples/SerialDisplay/SerialDisplay.ino

@@ -10,7 +10,7 @@ LiquidCrystal_I2C lcd(0x27, 16, 2);
 
 void setup()
 {
-	lcd.init();
+	lcd.begin();
 	lcd.backlight();
 
 	// Initialize the serial port at a speed of 9600 baud