Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jonkykong/SideMenu
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: spint01/SideMenu
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 5 files changed
  • 2 contributors

Commits on Dec 30, 2016

  1. Issue: Present a modal ViewController while the menu is open on a 6/7… 

    … Plus in Portrait mode, rotate device to landscape, modal VC will close and app will crash when attempting to access the menu again.

This is a partial fix which prevents the modal VC from closing. A better fix would be for the menu to never close automatically.
    Steve Pint authored and Steve Pint committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    5bf27f4 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2017

  1. Send a notification when the menu is displayed and when it is hidden.

    Steve Pint authored and Steve Pint committed Feb 2, 2017
    Configuration menu
    Copy the full SHA
    caca7f9 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2017

  1. Status bar hiding/showing is handled within the app, not needed here

    Steve Pint authored and Steve Pint committed Feb 21, 2017
    Configuration menu
    Copy the full SHA
    499be7a View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2017

  1. Merge branch 'master' of github.com:jonkykong/SideMenu

    Steve Pint committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    3a1bb92 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2017

  1. convert to Swift 4.0

    Steve Pint committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    e8ff926 View commit details
    Browse the repository at this point in the history

  2. Another fix for swift 4.0

    Steve Pint committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    099c5c2 View commit details
    Browse the repository at this point in the history
Loading