Skip to content

Commit 035d7a7

Browse files
authored
Merge pull request JanKaul#183 from splitgraph/non-empty-default-catalog
feat: don't set default_catalog in view builders if catalog name is empty
2 parents 25455dc + 3281c56 commit 035d7a7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

iceberg-rust/src/catalog/create.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ impl CreateViewBuilder<Option<()>> {
221221
if version.default_namespace().is_empty() {
222222
version.default_namespace = namespace.to_vec()
223223
}
224-
if version.default_catalog().is_none() {
224+
if version.default_catalog().is_none() && !catalog.name().is_empty() {
225225
version.default_catalog = Some(catalog.name().to_string())
226226
}
227227
}
@@ -349,7 +349,7 @@ impl CreateMaterializedViewBuilder {
349349
if version.default_namespace().is_empty() {
350350
version.default_namespace = namespace.to_vec()
351351
}
352-
if version.default_catalog().is_none() {
352+
if version.default_catalog().is_none() && !catalog.name().is_empty() {
353353
version.default_catalog = Some(catalog.name().to_string())
354354
}
355355
}

0 commit comments

Comments
 (0)