Skip to content

Commit 1ca3ba2

Browse files
Patrick SandifordPatrick Sandiford
Patrick Sandiford
authored and
Patrick Sandiford
committed
adding and deleting seem to work fine now
1 parent 6dc2a83 commit 1ca3ba2

File tree

3 files changed

+16
-12
lines changed

3 files changed

+16
-12
lines changed

swift_browser/templates/containers.html

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,7 @@
4343
</button>
4444
<ul class="dropdown-menu">
4545
<li>
46-
<form action="{% url 'delete_container' %}" method="POST">
47-
{% csrf_token %}
48-
<input type="hidden" name="container" value="{{container.name}}"/>
49-
<a href="#" onclick="event.preventDefault(); this.parentNode.submit()">Delete</a>
50-
<!-- TODO: Confirm -->
51-
</form>
46+
<a href="{% url 'delete_container' %}?container={{container.name}}" onclick="return confirm('Delete {{container.name}}?');">Delete</a>
5247
</li>
5348
</ul>
5449
</div>

swift_browser/templates/create_container.html

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{% extends "base.html" %}
2+
{% load bootstrap3 %}
23
{% block content %}
34

45
<div class="container">
@@ -8,10 +9,10 @@
89
<li><a href="{% url 'containers' %}">Containers</a></li>
910
</ul>
1011

11-
<form method="POST" action="{% url 'create_container' %}" class="form-horizontal">
12+
<form method="POST" action="{% url 'create_container' %}">
1213
{% csrf_token %}
13-
{{ form }}
14-
<input type="submit" value="Submit"/>
14+
{% bootstrap_form form%}
15+
{% bootstrap_button 'Create Container' button_type='submit' %}
1516
</form>
1617
</div>
1718

swift_browser/views.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def create_container(request):
145145
if request.method == 'POST':
146146
form = CreateContainerForm(request.POST)
147147
if form.is_valid():
148-
container = form.cleaned_data['container_name']
148+
container = form.cleaned_data['container']
149149
try:
150150
http_conn = (urlparse(storage_url),
151151
client.HTTPConnection(storage_url, insecure=settings.SWIFT_SSL_INSECURE))
@@ -162,18 +162,26 @@ def create_container(request):
162162

163163

164164
@login_required
165-
def delete_container(request, container, prefix=None):
165+
def delete_container(request):
166166
auth_token = request.session['auth_token']
167167
storage_url = request.session['storage_url']
168168

169+
container = ''
170+
if 'container' in request.GET.keys():
171+
container = request.GET['container']
172+
else:
173+
return redirect(containers)
174+
169175
try:
170176
http_conn = (urlparse(storage_url),
171177
client.HTTPConnection(storage_url, insecure=settings.SWIFT_SSL_INSECURE))
172178
_m, objects = client.get_container(storage_url, auth_token, container, http_conn=http_conn)
173179
for obj in objects:
180+
logger.info("Deleting object %s in container %s" % (obj['name'], container))
174181
client.delete_object(storage_url, auth_token,
175182
container, obj['name'], http_conn=http_conn)
176-
client.delete_container(storage_url, auth_token, container)
183+
logger.info("Deleting container %s" % (container))
184+
client.delete_container(storage_url, auth_token, container, http_conn=http_conn)
177185
messages.add_message(request, messages.INFO, "Container deleted.")
178186
except client.ClientException:
179187
messages.add_message(request, messages.ERROR, "Access denied.")

0 commit comments

Comments
 (0)