Skip to content

dimensions package dependency #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
montasaurus opened this issue Sep 28, 2016 · 3 comments
Closed

dimensions package dependency #5

montasaurus opened this issue Sep 28, 2016 · 3 comments

Comments

@montasaurus
Copy link

Hi, I got some npm errors when I went to use this package.

It seems like the dimensions npm package is being referenced, but isn't declared as a dependency in package.json. The dimensions library has a further dependency on fs, which doesn't appear to be available from a react native environment.

It looks like it would be safe to just remove this dependency completely, along with the SCREEN_WIDTH and SCREEN_HEIGHT properties.

@sreejithr
Copy link
Owner

@howitzer-industries You're right, since we're not using SCREEN_WIDTH and SCREEN_HEIGHT anywhere, we can remove these lines. But Dimensions is not an external dependency, you see. It is part of react-native (link).

@sreejithr
Copy link
Owner

sreejithr commented Sep 29, 2016

@howitzer-industries I was able to reproduce the error you were mentioning. I've made a pull request fixing the issue.

Edit: Merged.

@sreejithr
Copy link
Owner

@howitzer-industries This fix and couple of other fixes and features have been released as v1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants