Issue mozilla-mobile#2346: Fix Kotlin compiler warnings in support-ktx.

Author: pocmo

buildSrc/src/main/java/KotlinCompiler.kt

@@ -43,7 +43,6 @@ object KotlinCompiler {
         "service-firefox-accounts",
         "service-fretboard",
         "service-glean",
-        "support-ktx",
         "support-test",
         "support-utils",
         "tooling-lint",

components/support/ktx/src/test/java/mozilla/components/support/ktx/android/content/res/ResourcesTest.kt

@@ -1,6 +1,8 @@
 package mozilla.components.support.ktx.android.content.res
 
+import android.content.Context
 import android.util.DisplayMetrics
+import androidx.test.core.app.ApplicationProvider
 import org.junit.Assert
 import org.junit.Test
 import org.junit.runner.RunWith
@@ -9,11 +11,12 @@ import org.robolectric.RuntimeEnvironment
 
 @RunWith(RobolectricTestRunner::class)
 class ResourcesTest {
+    private val context: Context
+        get() = ApplicationProvider.getApplicationContext()
 
     @Test
     fun `dp returns same value as manual conversion`() {
-
-        val resources = RuntimeEnvironment.application.resources
+        val resources = context.resources
         val metrics = resources.displayMetrics
 
         for (i in 1..500) {

components/support/ktx/src/test/java/mozilla/components/support/ktx/android/os/StrictModeTest.kt

@@ -39,7 +39,7 @@ class StrictModeTest {
                 StrictMode.setThreadPolicy(this)
             }
 
-        var exceptionCaught = false
+        val exceptionCaught: Boolean
 
         assertEquals(policy.toString(), StrictMode.getThreadPolicy().toString())
 

components/support/ktx/src/test/java/mozilla/components/support/ktx/android/view/ViewTest.kt

@@ -4,24 +4,28 @@
 
 package mozilla.components.support.ktx.android.view
 
+import android.content.Context
 import android.view.View
 import android.widget.EditText
 import android.widget.TextView
+import androidx.test.core.app.ApplicationProvider
 import mozilla.components.support.base.android.Padding
 import org.junit.Assert.assertEquals
 import org.junit.Assert.assertFalse
 import org.junit.Assert.assertTrue
 import org.junit.Test
 import org.junit.runner.RunWith
 import org.robolectric.RobolectricTestRunner
-import org.robolectric.RuntimeEnvironment
 import org.robolectric.shadows.ShadowLooper
 
 @RunWith(RobolectricTestRunner::class)
 class ViewTest {
+    private val context: Context
+        get() = ApplicationProvider.getApplicationContext()
+
     @Test
     fun `showKeyboard should request focus`() {
-        val view = EditText(RuntimeEnvironment.application)
+        val view = EditText(context)
         assertFalse(view.hasFocus())
 
         view.showKeyboard()
@@ -32,7 +36,7 @@ class ViewTest {
 
     @Test
     fun `visibility helper methods`() {
-        val view = TextView(RuntimeEnvironment.application)
+        val view = TextView(context)
 
         view.visibility = View.GONE
 
@@ -55,7 +59,7 @@ class ViewTest {
 
     @Test
     fun `setPadding should set padding`() {
-        val view = TextView(RuntimeEnvironment.application)
+        val view = TextView(context)
 
         assertEquals(view.paddingLeft, 0)
         assertEquals(view.paddingTop, 0)