Skip to content

Bug: Composite requirements are ignored in JSON export #2180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fniu opened this issue Apr 24, 2025 · 3 comments
Open

Bug: Composite requirements are ignored in JSON export #2180

fniu opened this issue Apr 24, 2025 · 3 comments
Milestone

Comments

@fniu
Copy link

fniu commented Apr 24, 2025

Describe the bug

Composite requirements are not included in the JSON export. It is simply exported to an empty dict {}.

@stanislaw
Copy link
Collaborator

Hi @fniu,

As the doc states it here, the composite requirements have not received enough development until now because no one requested this strongly enough.

Could you describe your use case and whether you need to work with composite requirements strongly? Just implementing the JSON export should be pretty easy, the question is if you are intending to use this feature in general.

One recent idea that I had about this was to merge Section, Requirement, Composite Requirement into just ONE node and that node would be controlled with a grammar as to whether this node is composite or not. Unfortunately, doing this seemingly easy change would require a pretty massive refactoring of the codebase which I would not initiate until there is a really strong need.

Thanks.

@fniu
Copy link
Author

fniu commented Apr 26, 2025

I don't have a strong need of using composite requirements. There are perhaps two instances of composite requirements which can be avoided. So there is no need to rush any decision on this.

@stanislaw
Copy link
Collaborator

Hey @fniu, just a heads up: I have other reasons to improve the composite node support. @mettta and I have started working on an incremental migration here: #2193. In a few days / weeks, we should be able to implement the JSON support as well.

A spoiler: The composite nodes will have a new syntax: [[NODE]] ... [[/NODE]]. The COMPOSITE_... will be removed from the grammar eventually.

@stanislaw stanislaw added this to the 2025-Q2 milestone May 10, 2025
@stanislaw stanislaw modified the milestones: 2025-Q2, 2025-Q3 Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants