refactor: change callbacks to async functions

Author: nabdelgadir

common/models/coffee-shop.js

@@ -4,19 +4,19 @@
 'use strict';
 
 module.exports = function(CoffeeShop) {
-  CoffeeShop.status = function(cb) {
-    var currentDate = new Date();
-    var currentHour = currentDate.getHours();
-    var OPEN_HOUR = 6;
-    var CLOSE_HOUR = 20;
+  CoffeeShop.status = async function() {
+    const currentDate = new Date();
+    const currentHour = currentDate.getHours();
+    const OPEN_HOUR = 6;
+    const CLOSE_HOUR = 20;
     console.log('Current hour is %d', currentHour);
-    var response;
+    let response;
     if (currentHour > OPEN_HOUR && currentHour < CLOSE_HOUR) {
       response = 'We are open for business.';
     } else {
       response = 'Sorry, we are closed. Open daily from 6am to 8pm.';
     }
-    cb(null, response);
+    return response;
   };
   CoffeeShop.remoteMethod(
     'status', {

server/boot/create-sample-models.js

@@ -3,23 +3,19 @@
 
 'use strict';
 
-module.exports = function(app) {
-  app.dataSources.mysqlDs.automigrate('CoffeeShop', function(err) {
-    if (err) throw err;
+module.exports = async function(app) {
+  await app.dataSources.mysqlDs.automigrate('CoffeeShop');
+  const coffeeShops = await app.models.CoffeeShop.create([{
+    name: 'Bel Cafe',
+    city: 'Vancouver',
+  }, {
+    name: 'Three Bees Coffee House',
+    city: 'San Mateo',
+  }, {
+    name: 'Caffe Artigiano',
+    city: 'Vancouver',
+  },
+  ]);
 
-    app.models.CoffeeShop.create([{
-      name: 'Bel Cafe',
-      city: 'Vancouver',
-    }, {
-      name: 'Three Bees Coffee House',
-      city: 'San Mateo',
-    }, {
-      name: 'Caffe Artigiano',
-      city: 'Vancouver',
-    }], function(err, coffeeShops) {
-      if (err) throw err;
-
-      console.log('Models created: \n', coffeeShops);
-    });
-  });
+  console.log('Models created: \n', coffeeShops);
 };

server/config.json

@@ -5,6 +5,7 @@
   "remoting": {
     "context": false,
     "rest": {
+      "handleErrors": false,
       "normalizeHttpPath": false,
       "xml": false
     },
@@ -16,7 +17,6 @@
       "extended": true,
       "limit": "100kb"
     },
-    "cors": false,
-    "handleErrors": false
+    "cors": false
   }
 }

server/server.js

@@ -3,19 +3,19 @@
 
 'use strict';
 
-var loopback = require('loopback');
-var boot = require('loopback-boot');
+const loopback = require('loopback');
+const boot = require('loopback-boot');
 
-var app = module.exports = loopback();
+const app = module.exports = loopback();
 
 app.start = function() {
   // start the web server
   return app.listen(function() {
     app.emit('started');
-    var baseUrl = app.get('url').replace(/\/$/, '');
+    const baseUrl = app.get('url').replace(/\/$/, '');
     console.log('Web server listening at: %s', baseUrl);
     if (app.get('loopback-component-explorer')) {
-      var explorerPath = app.get('loopback-component-explorer').mountPath;
+      const explorerPath = app.get('loopback-component-explorer').mountPath;
       console.log('Browse your REST API at %s%s', baseUrl, explorerPath);
     }
   });