Skip to content

Commit c93d536

Browse files
committed
Set scheduler bindings in rabbitmq-env.bat for windows
rename SCHEDULING to SCHEDULER in line with erlang documentation
1 parent 179873d commit c93d536

File tree

4 files changed

+19
-22
lines changed

4 files changed

+19
-22
lines changed

scripts/rabbitmq-env

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,11 @@ RABBITMQ_HOME="$(rmq_realpath "${RABBITMQ_SCRIPTS_DIR}/..")"
6262
## Set defaults
6363
. ${RABBITMQ_SCRIPTS_DIR}/rabbitmq-defaults
6464

65-
DEFAULT_SCHEDULING_BIND_TYPE="tnnps"
66-
[ "x" = "x$RABBITMQ_SCHEDULING_BIND_TYPE" ] && RABBITMQ_SCHEDULING_BIND_TYPE=${DEFAULT_SCHEDULING_BIND_TYPE}
65+
DEFAULT_SCHEDULER_BIND_TYPE="tnnps"
66+
[ "x" = "x$RABBITMQ_SCHEDULER_BIND_TYPE" ] && RABBITMQ_SCHEDULER_BIND_TYPE=${DEFAULT_SCHEDULER_BIND_TYPE}
6767

6868
## Common defaults
69-
SERVER_ERL_ARGS="+P 1048576 +stbt $RABBITMQ_SCHEDULING_BIND_TYPE "
69+
SERVER_ERL_ARGS="+P 1048576 +stbt $RABBITMQ_SCHEDULER_BIND_TYPE "
7070

7171
# We save the current value of $RABBITMQ_PID_FILE in case it was set by
7272
# an init script. If $CONF_ENV_FILE overrides it again, we must ignore

scripts/rabbitmq-env.bat

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,14 @@ REM ## Set defaults
3030
REM . ${SCRIPT_DIR}/rabbitmq-defaults
3131
call "%SCRIPT_DIR%\rabbitmq-defaults.bat"
3232

33+
set DEFAULT_SCHEDULER_BIND_TYPE=tnnps
34+
REM [ "x" = "x$RABBITMQ_SCHEDULER_BIND_TYPE" ] && RABBITMQ_SCHEDULER_BIND_TYPE=${DEFAULT_SCHEDULER_BIND_TYPE}
35+
36+
REM set the default scheduling bind type
37+
if "!RABBITMQ_SCHEDULER_BIND_TYPE!"=="" (
38+
set RABBITMQ_SCHEDULER_BIND_TYPE=!DEFAULT_SCHEDULER_BIND_TYPE!
39+
)
40+
3341
REM These common defaults aren't referenced in the batch scripts
3442
REM ## Common defaults
3543
REM SERVER_ERL_ARGS="+P 1048576"
@@ -41,9 +49,8 @@ REM echo -n "WARNING: ignoring /etc/rabbitmq/rabbitmq.conf -- "
4149
REM echo "location has moved to ${CONF_ENV_FILE}"
4250
REM fi
4351

44-
REM ERL_ARGS aren't referenced in the batch scripts
4552
REM Common defaults
46-
REM set SERVER_ERL_ARGS=+P 1048576
53+
set SERVER_ERL_ARGS=+P 1048576 +stbt !RABBITMQ_SCHEDULER_BIND_TYPE!
4754

4855
REM ## Get configuration variables from the configure environment file
4956
REM [ -f ${CONF_ENV_FILE} ] && . ${CONF_ENV_FILE} || true
@@ -151,7 +158,9 @@ if "!RABBITMQ_DIST_PORT!"=="" (
151158
)
152159

153160
REM [ "x" = "x$RABBITMQ_SERVER_ERL_ARGS" ] && RABBITMQ_SERVER_ERL_ARGS=${SERVER_ERL_ARGS}
154-
REM No Windows equivalent
161+
if "!RABBITMQ_SERVER_ERL_ARGS!"=="" (
162+
set RABBITMQ_SERVER_ERL_ARGS=!SERVER_ERL_ARGS!
163+
)
155164

156165
REM [ "x" = "x$RABBITMQ_CONFIG_FILE" ] && RABBITMQ_CONFIG_FILE=${CONFIG_FILE}
157166
if "!RABBITMQ_CONFIG_FILE!"=="" (
@@ -386,8 +395,8 @@ goto :filter_paths_done
386395
set paths=%1
387396
set paths=%paths:"=%
388397
for /f "tokens=1* delims=;" %%a in ("%paths%") do (
389-
if not "%%a" == "" call :filter_path %%a
390-
if not "%%b" == "" call :filter_paths %%b
398+
if not "%%a" == "" call :filter_path "%%a"
399+
if not "%%b" == "" call :filter_paths "%%b"
391400
)
392401
set paths=
393402
exit /b

scripts/rabbitmq-server.bat

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -112,10 +112,6 @@ if "!ENV_OK!"=="false" (
112112
EXIT /b 78
113113
)
114114

115-
if "!RABBITMQ_SCHEDULING_BIND_TYPE!"=="" (
116-
set RABBITMQ_SCHEDULING_BIND_TYPE="tnnps"
117-
)
118-
119115
"!ERLANG_HOME!\bin\erl.exe" ^
120116
-pa "!RABBITMQ_EBIN_ROOT!" ^
121117
-boot start_sasl ^
@@ -124,10 +120,8 @@ if "!RABBITMQ_SCHEDULING_BIND_TYPE!"=="" (
124120
!RABBITMQ_NAME_TYPE! !RABBITMQ_NODENAME! ^
125121
+W w ^
126122
+A "!RABBITMQ_IO_THREAD_POOL_SIZE!" ^
127-
+stbt "!RABBITMQ_SCHEDULING_BIND_TYPE!" ^
128-
+P 1048576 ^
129-
!RABBITMQ_LISTEN_ARG! ^
130123
!RABBITMQ_SERVER_ERL_ARGS! ^
124+
!RABBITMQ_LISTEN_ARG! ^
131125
-kernel inet_default_connect_options "[{nodelay, true}]" ^
132126
!RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS! ^
133127
-sasl errlog_type error ^

scripts/rabbitmq-service.bat

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -173,21 +173,15 @@ if "!RABBITMQ_SERVICE_RESTART!"=="" (
173173
set RABBITMQ_SERVICE_RESTART=restart
174174
)
175175

176-
if "!RABBITMQ_SCHEDULING_BIND_TYPE!"=="" (
177-
set RABBITMQ_SCHEDULING_BIND_TYPE="tnnps"
178-
)
179-
180176
set ERLANG_SERVICE_ARGUMENTS= ^
181177
-pa "!RABBITMQ_EBIN_ROOT!" ^
182178
-boot start_sasl ^
183179
!RABBITMQ_START_RABBIT! ^
184180
!RABBITMQ_CONFIG_ARG! ^
185181
+W w ^
186182
+A "!RABBITMQ_IO_THREAD_POOL_SIZE!" ^
187-
+stbt "!RABBITMQ_SCHEDULING_BIND_TYPE!" ^
188-
+P 1048576 ^
189-
!RABBITMQ_LISTEN_ARG! ^
190183
!RABBITMQ_SERVER_ERL_ARGS! ^
184+
!RABBITMQ_LISTEN_ARG! ^
191185
-kernel inet_default_connect_options "[{nodelay,true}]" ^
192186
!RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS! ^
193187
-sasl errlog_type error ^

0 commit comments

Comments
 (0)