Skip to content

Python 3 support #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sh4nks opened this issue Nov 21, 2013 · 4 comments
Closed

Python 3 support #2

sh4nks opened this issue Nov 21, 2013 · 4 comments

Comments

@sh4nks
Copy link
Contributor

sh4nks commented Nov 21, 2013

Any plans on supporting it?

@sysr-q
Copy link
Owner

sysr-q commented Nov 22, 2013

I don't actually really have Python 3 w/ Flask installed since I deploy to 2.7.3 mainly.
What particular issues rise up in py3k? I'll have a gander, since cross-compatibility would be fine.

@sysr-q
Copy link
Owner

sysr-q commented Nov 22, 2013

Oh - I saw you seemed to have added it in your fork. If you want to send a pull request I'll merge it in and put it on the PyPI.

@sh4nks
Copy link
Contributor Author

sh4nks commented Nov 22, 2013

I also have modified the setup.py and merged the version.py into the __init__.py. This is my first attempt to port something to python3.. so any suggestions are welcome :)

@sysr-q
Copy link
Owner

sysr-q commented Nov 22, 2013

I just did the bad version.py hack because I wanted to easily execfile() in the __version__ without having to remember to change it in two places.
Feel free to open a pull request any time and I'll be more than happy to merge it in, it all looks pretty solid from my quick gander.

@sysr-q sysr-q closed this as completed Nov 29, 2013
smurfix pushed a commit to smurfix/flask-themes2 that referenced this issue Feb 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants