Skip to content

Create password history when commit = True #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gBobCodes opened this issue Sep 3, 2015 · 2 comments
Closed

Create password history when commit = True #43

gBobCodes opened this issue Sep 3, 2015 · 2 comments

Comments

@gBobCodes
Copy link
Contributor

I propose that the creation of a PasswordHistory record should only occur when the 'commit' parameter is True. This allows a sub-form to make the call object = form.save(commit=False) to get the user object without creating a history record.

File: forms/init.py
class PasswordPoliciesForm
method save()
Code: Indent lines 95 to 99.

@tarak
Copy link
Owner

tarak commented Sep 4, 2015

Ok. Have you tried to run the tests with the change you are proposing and would it be necessary to add more testing? A PR is always appreciated...

@gBobCodes
Copy link
Contributor Author

I am working on testing the change.

@tarak tarak closed this as completed in 76c8066 Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants