Skip to content

driver: fix yield in fifottl/utubettl #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

oleg-jukovec
Copy link
Collaborator

After 1000 processed tuples an iteration fiber yields after each processed tuple. The problem was fixed by resetting a counter of processed tuples without yield.

Closes #208

@oleg-jukovec oleg-jukovec requested review from 0x501D and GRISHNOV and removed request for GRISHNOV June 14, 2023 09:22
Copy link
Contributor

@LeonidVas LeonidVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! thank you for the patch.
About the title of the commit: "bugfix" not is some subsystem, replace it with something like: "driver: fix yield in fifottl/utubettl".

After 1000 processed tuples an iteration fiber yields after each
processed tuple. The problem was fixed by resetting a counter of
processed tuples without yield.

Closes #208
@oleg-jukovec oleg-jukovec force-pushed the oleg-jukovec/gh-208-too-often-yields branch from 0694fc1 to 2392df5 Compare June 14, 2023 14:01
@oleg-jukovec oleg-jukovec changed the title bugfix: fifottl/utubettl yield every time driver: fix yield in fifottl/utubettl Jun 14, 2023
@oleg-jukovec
Copy link
Collaborator Author

with something like: "driver: fix yield in fifottl/utubettl".

Updated.

@LeonidVas LeonidVas merged commit a681590 into master Jun 15, 2023
@LeonidVas LeonidVas deleted the oleg-jukovec/gh-208-too-often-yields branch June 15, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for infinite loop and sleep after 1000 success iterations for fifottl
3 participants