For mozilla-mobile#191 - Test that getSuggestions throws an exception with bad json

Author: boek

components/browser/search/src/main/java/mozilla/components/browser/search/SearchSuggestionClient.kt

@@ -1,6 +1,5 @@
 package mozilla.components.browser.search
 
-import mozilla.components.browser.search.parser.defaultParser
 import mozilla.components.browser.search.parser.selectParser
 
 typealias SearchSuggestionFetcher = suspend (url: String) -> String?

components/browser/search/src/test/java/mozilla/components/browser/search/SearchSuggestionClientTest.kt

@@ -6,6 +6,7 @@ package mozilla.components.browser.search
 
 import kotlinx.coroutines.experimental.runBlocking
 import org.json.JSONArray
+import org.json.JSONException
 import org.junit.Test
 import org.junit.runner.RunWith
 import org.junit.Assert.assertEquals
@@ -17,6 +18,7 @@ class SearchSuggestionClientTest {
     companion object {
         val GOOGLE_MOCK_RESPONSE: SearchSuggestionFetcher = { "[\"firefox\",[\"firefox\",\"firefox for mac\",\"firefox quantum\",\"firefox update\",\"firefox esr\",\"firefox focus\",\"firefox addons\",\"firefox extensions\",\"firefox nightly\",\"firefox clear cache\"]]" }
         val QWANT_MOCK_RESPONSE: SearchSuggestionFetcher = { "{\"status\":\"success\",\"data\":{\"items\":[{\"value\":\"firefox (video game)\",\"suggestType\":3},{\"value\":\"firefox addons\",\"suggestType\":12},{\"value\":\"firefox\",\"suggestType\":2},{\"value\":\"firefox quantum\",\"suggestType\":12},{\"value\":\"firefox focus\",\"suggestType\":12}],\"special\":[],\"availableQwick\":[]}}" }
+        val SERVER_ERROR_RESPONSE: SearchSuggestionFetcher = { "Server error. Try again later" }
     }
 
     @Test
@@ -50,4 +52,17 @@ class SearchSuggestionClientTest {
             assertEquals(expectedResults, results)
         }
     }
+
+    @Test(expected = JSONException::class)
+    fun `Check that a bad response will throw an exception`() {
+        val searchEngine = SearchEngineParser().load(
+                RuntimeEnvironment.application.assets,
+                "google", "searchplugins/google-nocodes.xml")
+
+        val client = SearchSuggestionClient(searchEngine, SERVER_ERROR_RESPONSE)
+
+        runBlocking {
+            client.getSuggestions("firefox")
+        }
+    }
 }