Skip to content

Commit ce93105

Browse files
authored
Merge branch 'master' into master
2 parents 13cc619 + cddac92 commit ce93105

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

.github/ISSUE_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212

1313

14-
## If this is a bug, how to reproduce? Please include a code sample if relevvant.
14+
## If this is a bug, how to reproduce? Please include a code sample if relevant.
1515

1616

1717

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ project adheres to [Semantic Versioning](http://semver.org/).
1111

1212
- `suspended_processes` to `worker_groups` input (by @bkmeneguello)
1313
- `target_group_arns` to `worker_groups` input (by @zihaoyu)
14+
- `force_detach_policies` to `aws_iam_role` `cluster` and `workers` (by @marky-mark)
1415
- `cluster_create_security_group` and `worker_create_security_group`. This allows using computed cluster and worker security groups. (by @rmakram-ims)
1516

1617
### Changed

cluster.tf

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,9 @@ resource "aws_security_group_rule" "cluster_https_worker_ingress" {
5050
}
5151

5252
resource "aws_iam_role" "cluster" {
53-
name_prefix = "${var.cluster_name}"
54-
assume_role_policy = "${data.aws_iam_policy_document.cluster_assume_role_policy.json}"
53+
name_prefix = "${var.cluster_name}"
54+
assume_role_policy = "${data.aws_iam_policy_document.cluster_assume_role_policy.json}"
55+
force_detach_policies = true
5556
}
5657

5758
resource "aws_iam_role_policy_attachment" "cluster_AmazonEKSClusterPolicy" {

workers.tf

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,9 @@ resource "aws_security_group_rule" "workers_ingress_cluster_https" {
105105
}
106106

107107
resource "aws_iam_role" "workers" {
108-
name_prefix = "${aws_eks_cluster.this.name}"
109-
assume_role_policy = "${data.aws_iam_policy_document.workers_assume_role_policy.json}"
108+
name_prefix = "${aws_eks_cluster.this.name}"
109+
assume_role_policy = "${data.aws_iam_policy_document.workers_assume_role_policy.json}"
110+
force_detach_policies = true
110111
}
111112

112113
resource "aws_iam_instance_profile" "workers" {

0 commit comments

Comments
 (0)