`Error: invalid topic name` when creating a FIFO Topic

[sfenman]

Description

When enabling FIFO SNS topic by using:

  fifo_topic                  = true
  content_based_deduplication = true

If I don't append the .fifo suffix in my topic name it throws an error: Error: invalid topic name: my-topic.

In terraform-aws-sqs module the .fifo suffix is appended automatically when creating a FIFO queue.

Let me know if I can open a PR with the change in case you think it would be better to do something similar for this module too.

[antonbabenko]

SQS queue must be FIFO as well. Please check an existing example in https://github.com/terraform-aws-modules/terraform-aws-sns/blob/master/examples/complete/main.tf

[sfenman]

Right I am using an SQS FIFO as well. What I meant is something similar to what the terraform-aws-sqs module does.

In the example you mentioned and if I set the use_name_prefix to false I get the same error:

[dustindortch]

Yes, it should check something like this that I have done in my own module:

locals {
  name  = var.fifo_topic && !endswith(var.name, ".fifo") && var.name != null ? join(".", [var.name, "fifo"]) : var.name
}

resource "aws_sns_topic" "this" {
  name = local.name
  ###
}

[bryantbiggs]

we could probably copy what we've done in the SQS module https://github.com/terraform-aws-modules/terraform-aws-sqs/blob/8c18f70fd765db2adf31edf5fc15b3058367e5a2/main.tf#L25

If someone wants to submit a PR, I'm happy to review

[bryantbiggs]

just don't forget to sanitize the name provided first https://github.com/terraform-aws-modules/terraform-aws-sqs/blob/8c18f70fd765db2adf31edf5fc15b3058367e5a2/main.tf#L10 - so whether users provide the .fifo or not, we ensure only one .fifo is added to the name when FIFO is enabled

[github-actions]

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

[antonbabenko]

This issue has been resolved in version 6.1.0 🎉

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.