fix: fixed bug that was preventing private only instance creation (#44)

Author: Ak-sky

cra-tf-validate-ignore-rules.json

@@ -1,11 +1,5 @@
 {
   "scc_rules": [
-    {
-      "scc_rule_id": "rule-3b2768e5-d783-4b0c-a47f-81479af34689",
-      "description": " Check whether Event Streams is accessible only by using private endpoints.",
-      "ignore_reason": "Failing due to known CRA bug (https://github.ibm.com/oneibmcloud/CD-CRA/issues/1820)",
-      "is_valid": false
-    },
     {
       "scc_rule_id": "rule-216e2449-27d7-4afc-929a-b66e196a9cf9",
       "description": "Check whether Flow Logs for VPC are enabled.",

main.tf

@@ -41,7 +41,7 @@ resource "ibm_resource_instance" "es_instance" {
   }
 
   parameters = {
-    service-endpoints = var.service_endpoints
+    service_endpoints = var.service_endpoints
     throughput        = var.throughput
     storage_size      = var.storage_size
     key_protect_key   = var.kms_key_crn

profiles/fscloud/README.md

@@ -1,9 +1,7 @@
 # Financial Services Cloud Profile
 
 This is a profile for Event Streams that meets Financial Services Cloud requirements.
-It has been scanned by [IBM Code Risk Analyzer (CRA)](https://cloud.ibm.com/docs/code-risk-analyzer-cli-plugin?topic=code-risk-analyzer-cli-plugin-cra-cli-plugin#terraform-command) and meets all applicable goals with the following exception:
-
-> Rule ID rule-3b2768e5-d783-4b0c-a47f-81479af34689 : Check whether Event Streams is accessible only by using private endpoints. This rule fails due to a known CRA bug (https://github.ibm.com/oneibmcloud/CD-CRA/issues/1820).
+It has been scanned by [IBM Code Risk Analyzer (CRA)](https://cloud.ibm.com/docs/code-risk-analyzer-cli-plugin?topic=code-risk-analyzer-cli-plugin-cra-cli-plugin#terraform-command) and meets all applicable goals.
 
 <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
 ## Requirements