Skip to content

Commit 778703d

Browse files
authored
feat: remove unused common folder (software-mansion#1838)
PR removing common directory from library since it is not used currently due to no custom shadow nodes etc. in Fabric implementation.
1 parent 0a26639 commit 778703d

File tree

5 files changed

+1
-55
lines changed

5 files changed

+1
-55
lines changed

.github/workflows/android-build-test.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ on:
44
paths:
55
- '.github/workflows/android-build-test.yml'
66
- 'android/**'
7-
- 'common/**'
87
- 'Example/android/**'
98
- 'FabricExample/android/**'
109
push:

FabricExample/ios/Podfile.lock

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -705,15 +705,6 @@ PODS:
705705
- React-Codegen
706706
- React-RCTFabric
707707
- ReactCommon/turbomodule/core
708-
- RNSVG/common (= 12.4.4)
709-
- RNSVG/common (12.4.4):
710-
- RCT-Folly
711-
- RCTRequired
712-
- RCTTypeSafety
713-
- React
714-
- React-Codegen
715-
- React-RCTFabric
716-
- ReactCommon/turbomodule/core
717708
- SocketRocket (0.6.0)
718709
- Yoga (1.14.0)
719710
- YogaKit (1.18.1):
@@ -936,7 +927,7 @@ SPEC CHECKSUMS:
936927
React-rncore: 55e35fbadf994c9efa605a78bf9d1fb3f080bc55
937928
React-runtimeexecutor: 538c4d995c729b5247ac3149774f0a53f98570dd
938929
ReactCommon: f7fc6b8b10e8f16f65a8009be266cfc1478fb20d
939-
RNSVG: 79c1551169ce176cc9eadd5e320c62b8912fe315
930+
RNSVG: 7b29007eb3f0c22975ee09c5cfab0459b1d78560
940931
SocketRocket: fccef3f9c5cedea1353a9ef6ada904fde10d6608
941932
Yoga: 65fe91a246110ebd54e9c7388d98e90d861cb4e7
942933
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a

RNSVG.podspec

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,6 @@ Pod::Spec.new do |s|
3838
s.dependency "RCTRequired"
3939
s.dependency "RCTTypeSafety"
4040
s.dependency "ReactCommon/turbomodule/core"
41-
42-
s.subspec "common" do |ss|
43-
ss.source_files = "common/cpp/**/*.{cpp,h}"
44-
ss.header_dir = "rnsvg"
45-
ss.pod_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_TARGET_SRCROOT)/common/cpp\"" }
46-
end
4741
else
4842
s.source_files = 'apple/**/*.{h,m,mm}'
4943
s.exclude_files = 'apple/Utils/RNSVGFabricConversions.h'

android/src/main/jni/Android.mk

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
SVG_MAIN_THIS_DIR := $(call my-dir)
22

33
include $(SVG_MAIN_THIS_DIR)/../../../build/generated/source/codegen/jni/Android.mk
4-
include $(SVG_MAIN_THIS_DIR)/../../../../common/cpp/Android.mk
54

65
include $(CLEAR_VARS)
76

common/cpp/Android.mk

Lines changed: 0 additions & 37 deletions
This file was deleted.

0 commit comments

Comments
 (0)