Remove unneeded method

Author: theospears

experiments/tests/webuser.py

@@ -105,7 +105,7 @@ def test_user_does_not_enroll(self):
     def test_bot_in_control_group(self):
         experiment_user = create_user(self.request)
         experiment_user.set_enrollment(self.experiment, TEST_ALTERNATIVE)
-        self.assertEqual(experiment_user.get_enrollment(self.experiment), CONTROL_GROUP, "Bot alternative is not control")
+        self.assertEqual(experiment_user.get_enrollment(self.experiment), None, "Bot enrolled in a group")
         self.assertEqual(experiment_user.is_enrolled(self.experiment.name, TEST_ALTERNATIVE, self.request), False, "Bot in test alternative")
         self.assertEqual(experiment_user.is_enrolled(self.experiment.name, CONTROL_GROUP, self.request), True, "Bot not in control group")
 

experiments/utils.py

@@ -95,7 +95,7 @@ def incorporate(self, other_user):
         This takes a relatively large amount of time for each experiment the other
         user is enrolled in."""
         for experiment, alternative in other_user._get_all_enrollments():
-            if not self._is_enrolled_in_experiment(experiment):
+            if not self.get_enrollment(experiment):
                 self.set_enrollment(experiment, alternative)
                 goals = experiment.participant_goal_frequencies(alternative, other_user._participant_identifier())
                 for goal_name, count in goals:
@@ -110,18 +110,14 @@ def _get_all_enrollments(self):
         "Return experiment, alternative tuples for all experiments the user is enrolled in"
         raise NotImplementedError
 
-    def _is_enrolled_in_experiment(self, experiment):
-        "Test whether the user currently has an enrollment in the supplied experiment"
-        raise NotImplementedError
-
     def _cancel_enrollment(self, experiment):
         "Remove the enrollment and any goals the user has against this experiment"
         raise NotImplementedError
 
 
 class DummyUser(WebUser):
     def get_enrollment(self, experiment):
-        return CONTROL_GROUP
+        return None
     def set_enrollment(self, experiment, alternative):
         pass
     def record_goal(self, goal_name, count=1):
@@ -180,9 +176,6 @@ def _get_all_enrollments(self):
             for enrollment in enrollments:
                 yield enrollment.experiment, enrollment.alternative
 
-    def _is_enrolled_in_experiment(self, experiment):
-        return Enrollment.objects.filter(user=self.user, experiment=experiment).exists()
-
     def _cancel_enrollment(self, experiment):
         try:
             enrollment = Enrollment.objects.get(user=self.user, experiment=experiment)
@@ -260,10 +253,6 @@ def _get_all_enrollments(self):
                 if experiment:
                     yield experiment, alternative
 
-    def _is_enrolled_in_experiment(self, experiment):
-        enrollments = self.session.get('experiments_enrollments', None)
-        return enrollments and experiment.name in enrollments
-
     def _cancel_enrollment(self, experiment):
         alternative = self.get_enrollment(experiment)
         if alternative: