compilers: remove hasattr for file_suffixes

This is used in exactly two cases, and it's just not worth it. Those two
cases can override the default set of extensions, and in the process
allow a nice bit of code cleanup, especially toward type checking.

Author: dcbaker

mesonbuild/compilers/compilers.py

@@ -452,8 +452,7 @@ def __init__(self, ccache: T.List[str], exelist: T.List[str], version: str,
         self.exelist = ccache + exelist
         self.exelist_no_ccache = exelist
         # In case it's been overridden by a child class already
-        if not hasattr(self, 'file_suffixes'):
-            self.file_suffixes = lang_suffixes[self.language]
+        self.file_suffixes = lang_suffixes[self.language]
         if not hasattr(self, 'can_compile_suffixes'):
             self.can_compile_suffixes: T.Set[str] = set(self.file_suffixes)
         self.default_suffix = self.file_suffixes[0]

mesonbuild/compilers/fortran.py

@@ -262,7 +262,6 @@ def openmp_flags(self, env: Environment) -> T.List[str]:
 
 class IntelFortranCompiler(IntelGnuLikeCompiler, FortranCompiler):
 
-    file_suffixes = ('f90', 'f', 'for', 'ftn', 'fpp', )
     id = 'intel'
 
     def __init__(self, exelist: T.List[str], version: str, for_machine: MachineChoice, is_cross: bool,
@@ -275,6 +274,7 @@ def __init__(self, exelist: T.List[str], version: str, for_machine: MachineChoic
         # FIXME: Add support for OS X and Windows in detect_fortran_compiler so
         # we are sent the type of compiler
         IntelGnuLikeCompiler.__init__(self)
+        self.file_suffixes = ('f90', 'f', 'for', 'ftn', 'fpp', )
         default_warn_args = ['-warn', 'general', '-warn', 'truncated_source']
         self.warn_args = {'0': [],
                           '1': default_warn_args,
@@ -318,7 +318,6 @@ class IntelLLVMFortranCompiler(IntelFortranCompiler):
 
 class IntelClFortranCompiler(IntelVisualStudioLikeCompiler, FortranCompiler):
 
-    file_suffixes = ('f90', 'f', 'for', 'ftn', 'fpp', )
     always_args = ['/nologo']
 
     def __init__(self, exelist: T.List[str], version: str, for_machine: MachineChoice,
@@ -329,6 +328,7 @@ def __init__(self, exelist: T.List[str], version: str, for_machine: MachineChoic
                                  is_cross, info, linker=linker,
                                  full_version=full_version)
         IntelVisualStudioLikeCompiler.__init__(self, target)
+        self.file_suffixes = ('f90', 'f', 'for', 'ftn', 'fpp', )
 
         default_warn_args = ['/warn:general', '/warn:truncated_source']
         self.warn_args = {'0': [],