JSHint cleanups

Author: Thom Seddon

.jshintignore

@@ -0,0 +1 @@
+node_modules

lib/authorise.js

@@ -78,8 +78,8 @@ authorise.getBearerToken = function (req, next) {
 		postToken = req.body.access_token;
 
 	// Check exactly one method was used
-	var methodsUsed = (typeof headerToken !== 'undefined') + (typeof getToken !== 'undefined')
-		+ (typeof postToken !== 'undefined');
+	var methodsUsed = (headerToken !== undefined) + (getToken !== undefined) +
+		(postToken !== undefined);
 
 	if (methodsUsed > 1) {
 		return next(new OAuth2Error('invalid_request',

lib/oauth2server.js

@@ -50,7 +50,7 @@ function OAuth2Server (config) {
 	this.regex = {};
 	this.regex.clientId = config.clientIdRegex || /^[a-z0-9-_]{3,40}$/i;
 	this.regex.grantType = new RegExp('^(' + this.grants.join('|') + ')$', 'i');
-};
+}
 
 /**
  * Authorise incoming requests
@@ -74,7 +74,7 @@ OAuth2Server.prototype.handler = function () {
 		if (allowed instanceof Array) {
 			allow = allowed;
 		} else {
-			allow = allow.concat(allowed['all'] || []);
+			allow = allow.concat(allowed.all || []);
 			allow = allow.concat(allowed[req.method.toLowerCase()] || []);
 		}
 
@@ -88,7 +88,7 @@ OAuth2Server.prototype.handler = function () {
 		} else {
 			return next();
 		}
-	}
+	};
 };
 
 /**
@@ -113,5 +113,5 @@ OAuth2Server.prototype.errorHandler = function () {
 		delete err.stack;
 
 		res.send(err.code, err);
-	}
+	};
 };

lib/token.js

@@ -124,7 +124,7 @@ token.grant = function (req, res, next) {
 			if (!supported) return invalid();
 
 			if (!user || user.id === undefined) {
-				return next(new OAuth2Error('invalid_request', 'Invalid request.'))
+				return next(new OAuth2Error('invalid_request', 'Invalid request.'));
 			}
 
 			req.user = user;

test/oauth2server.handle.js

@@ -65,7 +65,7 @@ describe('OAuth2Server.handle()', function() {
 			.expect(400)
 			.end(function (err, res) {
 				if (err) return done(err);
-				res.body.error_description.should.not.match(/the access token was not found/i)
+				res.body.error_description.should.not.match(/the access token was not found/i);
 				done();
 			});
 	});