Skip to content

Commit 6319f71

Browse files
harsha509manoj9788
harsha509
authored and
manoj9788
committed
Modify: Removed awaits for findElement (JavaScript) (SeleniumHQ#136)
* Modify: Removing await for findElement as findElement returns a resolved promise internally Signed-off-by: Sri Harsha <[email protected]> * Modify: Removed await for findElement (JavaScript) Signed-off-by: Sri Harsha <[email protected]> * Modify: Removed unneccessary awaits for findElement (JavaScript) Signed-off-by: Sri Harsha <[email protected]>
1 parent 48751dc commit 6319f71

24 files changed

+48
-48
lines changed

‎docs_source_files/content/webdriver/keyboard.de.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ const {Builder, By, Key} = require('selenium-webdriver');
338338
await driver.get('https://www.google.com');
339339

340340
// Store google search box WebElement
341-
let search = await driver.findElement(By.name('q'));
341+
let search = driver.findElement(By.name('q'));
342342

343343
// Enters text "qwerty" with keyDown SHIFT key and after keyUp SHIFT key (QWERTYqwerty)
344344
await driver.actions().click(search).keyDown(Key.SHIFT).sendKeys("qwerty").keyUp(Key.SHIFT).sendKeys("qwerty").perform();

‎docs_source_files/content/webdriver/keyboard.en.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ const {Builder, By, Key} = require('selenium-webdriver');
333333
await driver.get('https://www.google.com');
334334

335335
// Store google search box WebElement
336-
let search = await driver.findElement(By.name('q'));
336+
let search = driver.findElement(By.name('q'));
337337

338338
// Enters text "qwerty" with keyDown SHIFT key and after keyUp SHIFT key (QWERTYqwerty)
339339
await driver.actions().click(search).keyDown(Key.SHIFT).sendKeys("qwerty").keyUp(Key.SHIFT).sendKeys("qwerty").perform();

‎docs_source_files/content/webdriver/keyboard.es.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ const {Builder, By, Key} = require('selenium-webdriver');
339339
await driver.get('https://www.google.com');
340340

341341
// Store google search box WebElement
342-
let search = await driver.findElement(By.name('q'));
342+
let search = driver.findElement(By.name('q'));
343343

344344
// Enters text "qwerty" with keyDown SHIFT key and after keyUp SHIFT key (QWERTYqwerty)
345345
await driver.actions().click(search).keyDown(Key.SHIFT).sendKeys("qwerty").keyUp(Key.SHIFT).sendKeys("qwerty").perform();

‎docs_source_files/content/webdriver/keyboard.fr.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ const {Builder, By, Key} = require('selenium-webdriver');
339339
await driver.get('https://www.google.com');
340340

341341
// Store google search box WebElement
342-
let search = await driver.findElement(By.name('q'));
342+
let search = driver.findElement(By.name('q'));
343343

344344
// Enters text "qwerty" with keyDown SHIFT key and after keyUp SHIFT key (QWERTYqwerty)
345345
await driver.actions().click(search).keyDown(Key.SHIFT).sendKeys("qwerty").keyUp(Key.SHIFT).sendKeys("qwerty").perform();

‎docs_source_files/content/webdriver/keyboard.ja.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ const {Builder, By, Key} = require('selenium-webdriver');
338338
await driver.get('https://www.google.com');
339339

340340
// Store google search box WebElement
341-
let search = await driver.findElement(By.name('q'));
341+
let search = driver.findElement(By.name('q'));
342342

343343
// Enters text "qwerty" with keyDown SHIFT key and after keyUp SHIFT key (QWERTYqwerty)
344344
await driver.actions().click(search).keyDown(Key.SHIFT).sendKeys("qwerty").keyUp(Key.SHIFT).sendKeys("qwerty").perform();

‎docs_source_files/content/webdriver/keyboard.ko.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ const {Builder, By, Key} = require('selenium-webdriver');
339339
await driver.get('https://www.google.com');
340340

341341
// Store google search box WebElement
342-
let search = await driver.findElement(By.name('q'));
342+
let search = driver.findElement(By.name('q'));
343343

344344
// Enters text "qwerty" with keyDown SHIFT key and after keyUp SHIFT key (QWERTYqwerty)
345345
await driver.actions().click(search).keyDown(Key.SHIFT).sendKeys("qwerty").keyUp(Key.SHIFT).sendKeys("qwerty").perform();

‎docs_source_files/content/webdriver/keyboard.nl.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ const {Builder, By, Key} = require('selenium-webdriver');
339339
await driver.get('https://www.google.com');
340340

341341
// Store google search box WebElement
342-
let search = await driver.findElement(By.name('q'));
342+
let search = driver.findElement(By.name('q'));
343343

344344
// Enters text "qwerty" with keyDown SHIFT key and after keyUp SHIFT key (QWERTYqwerty)
345345
await driver.actions().click(search).keyDown(Key.SHIFT).sendKeys("qwerty").keyUp(Key.SHIFT).sendKeys("qwerty").perform();

‎docs_source_files/content/webdriver/keyboard.zh-cn.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ const {Builder, By, Key} = require('selenium-webdriver');
339339
await driver.get('https://www.google.com');
340340

341341
// Store google search box WebElement
342-
let search = await driver.findElement(By.name('q'));
342+
let search = driver.findElement(By.name('q'));
343343

344344
// Enters text "qwerty" with keyDown SHIFT key and after keyUp SHIFT key (QWERTYqwerty)
345345
await driver.actions().click(search).keyDown(Key.SHIFT).sendKeys("qwerty").keyUp(Key.SHIFT).sendKeys("qwerty").perform();

‎docs_source_files/content/webdriver/waits.de.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ end
7676
{{< / code-panel >}}
7777
{{< code-panel language="javascript" >}}
7878
await driver.get('file:///race_condition.html');
79-
const element = await driver.findElement(By.css('p'));
79+
const element = driver.findElement(By.css('p'));
8080
assert.strictEqual(await element.getText(), 'Hello from JavaScript!');
8181
{{< / code-panel >}}
8282
{{< code-panel language="kotlin" >}}
@@ -197,7 +197,7 @@ const documentInitialised = () =>
197197

198198
await driver.get('file:///race_condition.html');
199199
await driver.wait(() => documentInitialised(), 10000);
200-
const element = await driver.findElement(By.css('p'));
200+
const element = driver.findElement(By.css('p'));
201201
assert.strictEqual(await element.getText(), 'Hello from JavaScript!');
202202
{{< / code-panel >}}
203203
{{< code-panel language="kotlin" >}}
@@ -410,7 +410,7 @@ await driver.manage().setTimeouts( { implicit: 10000 } );
410410
// Navigate to url
411411
await driver.get('http://somedomain/url_that_delays_loading');
412412

413-
let webElement = await driver.findElement(By.id("myDynamicElement"));
413+
let webElement = driver.findElement(By.id("myDynamicElement"));
414414

415415
}());
416416
{{< / code-panel >}}

‎docs_source_files/content/webdriver/waits.en.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ end
7171
{{< / code-panel >}}
7272
{{< code-panel language="javascript" >}}
7373
await driver.get('file:///race_condition.html');
74-
const element = await driver.findElement(By.css('p'));
74+
const element = driver.findElement(By.css('p'));
7575
assert.strictEqual(await element.getText(), 'Hello from JavaScript!');
7676
{{< / code-panel >}}
7777
{{< code-panel language="kotlin" >}}
@@ -192,7 +192,7 @@ const documentInitialised = () =>
192192

193193
await driver.get('file:///race_condition.html');
194194
await driver.wait(() => documentInitialised(), 10000);
195-
const element = await driver.findElement(By.css('p'));
195+
const element = driver.findElement(By.css('p'));
196196
assert.strictEqual(await element.getText(), 'Hello from JavaScript!');
197197
{{< / code-panel >}}
198198
{{< code-panel language="kotlin" >}}
@@ -405,7 +405,7 @@ await driver.manage().setTimeouts( { implicit: 10000 } );
405405
// Navigate to url
406406
await driver.get('http://somedomain/url_that_delays_loading');
407407

408-
let webElement = await driver.findElement(By.id("myDynamicElement"));
408+
let webElement = driver.findElement(By.id("myDynamicElement"));
409409

410410
}());
411411
{{< / code-panel >}}

‎docs_source_files/content/webdriver/waits.es.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ end
7777
{{< / code-panel >}}
7878
{{< code-panel language="javascript" >}}
7979
await driver.get('file:///race_condition.html');
80-
const element = await driver.findElement(By.css('p'));
80+
const element = driver.findElement(By.css('p'));
8181
assert.strictEqual(await element.getText(), 'Hello from JavaScript!');
8282
{{< / code-panel >}}
8383
{{< code-panel language="kotlin" >}}
@@ -198,7 +198,7 @@ const documentInitialised = () =>
198198

199199
await driver.get('file:///race_condition.html');
200200
await driver.wait(() => documentInitialised(), 10000);
201-
const element = await driver.findElement(By.css('p'));
201+
const element = driver.findElement(By.css('p'));
202202
assert.strictEqual(await element.getText(), 'Hello from JavaScript!');
203203
{{< / code-panel >}}
204204
{{< code-panel language="kotlin" >}}
@@ -409,7 +409,7 @@ await driver.manage().setTimeouts( { implicit: 10000 } );
409409
// Navigate to url
410410
await driver.get('http://somedomain/url_that_delays_loading');
411411

412-
let webElement = await driver.findElement(By.id("myDynamicElement"));
412+
let webElement = driver.findElement(By.id("myDynamicElement"));
413413

414414
}());
415415
{{< / code-panel >}}

‎docs_source_files/content/webdriver/waits.fr.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ end
7777
{{< / code-panel >}}
7878
{{< code-panel language="javascript" >}}
7979
await driver.get('file:///race_condition.html');
80-
const element = await driver.findElement(By.css('p'));
80+
const element = driver.findElement(By.css('p'));
8181
assert.strictEqual(await element.getText(), 'Hello from JavaScript!');
8282
{{< / code-panel >}}
8383
{{< code-panel language="kotlin" >}}
@@ -198,7 +198,7 @@ const documentInitialised = () =>
198198

199199
await driver.get('file:///race_condition.html');
200200
await driver.wait(() => documentInitialised(), 10000);
201-
const element = await driver.findElement(By.css('p'));
201+
const element = driver.findElement(By.css('p'));
202202
assert.strictEqual(await element.getText(), 'Hello from JavaScript!');
203203
{{< / code-panel >}}
204204
{{< code-panel language="kotlin" >}}
@@ -410,7 +410,7 @@ await driver.manage().setTimeouts( { implicit: 10000 } );
410410
// Navigate to url
411411
await driver.get('http://somedomain/url_that_delays_loading');
412412

413-
let webElement = await driver.findElement(By.id("myDynamicElement"));
413+
let webElement = driver.findElement(By.id("myDynamicElement"));
414414

415415
}());
416416
{{< / code-panel >}}

‎docs_source_files/content/webdriver/waits.ja.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ end
7676
{{< / code-panel >}}
7777
{{< code-panel language="javascript" >}}
7878
await driver.get('file:///race_condition.html');
79-
const element = await driver.findElement(By.css('p'));
79+
const element = driver.findElement(By.css('p'));
8080
assert.strictEqual(await element.getText(), 'Hello from JavaScript!');
8181
{{< / code-panel >}}
8282
{{< code-panel language="kotlin" >}}
@@ -197,7 +197,7 @@ const documentInitialised = () =>
197197

198198
await driver.get('file:///race_condition.html');
199199
await driver.wait(() => documentInitialised(), 10000);
200-
const element = await driver.findElement(By.css('p'));
200+
const element = driver.findElement(By.css('p'));
201201
assert.strictEqual(await element.getText(), 'Hello from JavaScript!');
202202
{{< / code-panel >}}
203203
{{< code-panel language="kotlin" >}}
@@ -409,7 +409,7 @@ await driver.manage().setTimeouts( { implicit: 10000 } );
409409
// Navigate to url
410410
await driver.get('http://somedomain/url_that_delays_loading');
411411

412-
let webElement = await driver.findElement(By.id("myDynamicElement"));
412+
let webElement = driver.findElement(By.id("myDynamicElement"));
413413

414414
}());
415415
{{< / code-panel >}}

‎docs_source_files/content/webdriver/waits.ko.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ end
7777
{{< / code-panel >}}
7878
{{< code-panel language="javascript" >}}
7979
await driver.get('file:///race_condition.html');
80-
const element = await driver.findElement(By.css('p'));
80+
const element = driver.findElement(By.css('p'));
8181
assert.strictEqual(await element.getText(), 'Hello from JavaScript!');
8282
{{< / code-panel >}}
8383
{{< code-panel language="kotlin" >}}
@@ -198,7 +198,7 @@ const documentInitialised = () =>
198198

199199
await driver.get('file:///race_condition.html');
200200
await driver.wait(() => documentInitialised(), 10000);
201-
const element = await driver.findElement(By.css('p'));
201+
const element = driver.findElement(By.css('p'));
202202
assert.strictEqual(await element.getText(), 'Hello from JavaScript!');
203203
{{< / code-panel >}}
204204
{{< code-panel language="kotlin" >}}
@@ -411,7 +411,7 @@ await driver.manage().setTimeouts( { implicit: 10000 } );
411411
// Navigate to url
412412
await driver.get('http://somedomain/url_that_delays_loading');
413413

414-
let webElement = await driver.findElement(By.id("myDynamicElement"));
414+
let webElement = driver.findElement(By.id("myDynamicElement"));
415415

416416
}());
417417
{{< / code-panel >}}

‎docs_source_files/content/webdriver/waits.nl.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ end
7777
{{< / code-panel >}}
7878
{{< code-panel language="javascript" >}}
7979
await driver.get('file:///race_condition.html');
80-
const element = await driver.findElement(By.css('p'));
80+
const element = driver.findElement(By.css('p'));
8181
assert.strictEqual(await element.getText(), 'Hello from JavaScript!');
8282
{{< / code-panel >}}
8383
{{< code-panel language="kotlin" >}}
@@ -198,7 +198,7 @@ const documentInitialised = () =>
198198

199199
await driver.get('file:///race_condition.html');
200200
await driver.wait(() => documentInitialised(), 10000);
201-
const element = await driver.findElement(By.css('p'));
201+
const element = driver.findElement(By.css('p'));
202202
assert.strictEqual(await element.getText(), 'Hello from JavaScript!');
203203
{{< / code-panel >}}
204204
{{< code-panel language="kotlin" >}}
@@ -409,7 +409,7 @@ await driver.manage().setTimeouts( { implicit: 10000 } );
409409
// Navigate to url
410410
await driver.get('http://somedomain/url_that_delays_loading');
411411

412-
let webElement = await driver.findElement(By.id("myDynamicElement"));
412+
let webElement = driver.findElement(By.id("myDynamicElement"));
413413

414414
}());
415415
{{< / code-panel >}}

‎docs_source_files/content/webdriver/waits.zh-cn.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ end
7676
{{< / code-panel >}}
7777
{{< code-panel language="javascript" >}}
7878
await driver.get('file:///race_condition.html');
79-
const element = await driver.findElement(By.css('p'));
79+
const element = driver.findElement(By.css('p'));
8080
assert.strictEqual(await element.getText(), 'Hello from JavaScript!');
8181
{{< / code-panel >}}
8282
{{< code-panel language="kotlin" >}}
@@ -197,7 +197,7 @@ const documentInitialised = () =>
197197

198198
await driver.get('file:///race_condition.html');
199199
await driver.wait(() => documentInitialised(), 10000);
200-
const element = await driver.findElement(By.css('p'));
200+
const element = driver.findElement(By.css('p'));
201201
assert.strictEqual(await element.getText(), 'Hello from JavaScript!');
202202
{{< / code-panel >}}
203203
{{< code-panel language="kotlin" >}}
@@ -409,7 +409,7 @@ await driver.manage().setTimeouts( { implicit: 10000 } );
409409
// Navigate to url
410410
await driver.get('http://somedomain/url_that_delays_loading');
411411

412-
let webElement = await driver.findElement(By.id("myDynamicElement"));
412+
let webElement = driver.findElement(By.id("myDynamicElement"));
413413

414414
}());
415415
{{< / code-panel >}}

‎docs_source_files/content/webdriver/web_element.de.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,10 @@ driver = new Builder().forBrowser('chrome').build();
6464
await driver.get('http://www.google.com');
6565

6666
//Get and store DOM element '<form>'
67-
let searchForm = await driver.findElement(By.name('f'));
67+
let searchForm = driver.findElement(By.name('f'));
6868

6969
//Get search box element from webElement 'form'
70-
let searchBar = await searchForm.findElement(By.name('q'));
70+
let searchBar = searchForm.findElement(By.name('q'));
7171

7272
//Perform action using WebElement
7373
await searchBar.sendKeys('Webdriver');

‎docs_source_files/content/webdriver/web_element.en.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@ driver = new Builder().forBrowser('chrome').build();
5858
await driver.get('http://www.google.com');
5959

6060
//Get and store DOM element '<form>'
61-
let searchForm = await driver.findElement(By.name('f'));
61+
let searchForm = driver.findElement(By.name('f'));
6262

6363
//Get search box element from webElement 'form'
64-
let searchBar = await searchForm.findElement(By.name('q'));
64+
let searchBar = searchForm.findElement(By.name('q'));
6565

6666
//Perform action using WebElement
6767
await searchBar.sendKeys('Webdriver');

‎docs_source_files/content/webdriver/web_element.es.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,10 @@ driver = new Builder().forBrowser('chrome').build();
6464
await driver.get('http://www.google.com');
6565

6666
//Get and store DOM element '<form>'
67-
let searchForm = await driver.findElement(By.name('f'));
67+
let searchForm = driver.findElement(By.name('f'));
6868

6969
//Get search box element from webElement 'form'
70-
let searchBar = await searchForm.findElement(By.name('q'));
70+
let searchBar = searchForm.findElement(By.name('q'));
7171

7272
//Perform action using WebElement
7373
await searchBar.sendKeys('Webdriver');

‎docs_source_files/content/webdriver/web_element.fr.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,10 @@ driver = new Builder().forBrowser('chrome').build();
6464
await driver.get('http://www.google.com');
6565

6666
//Get and store DOM element '<form>'
67-
let searchForm = await driver.findElement(By.name('f'));
67+
let searchForm = driver.findElement(By.name('f'));
6868

6969
//Get search box element from webElement 'form'
70-
let searchBar = await searchForm.findElement(By.name('q'));
70+
let searchBar = searchForm.findElement(By.name('q'));
7171

7272
//Perform action using WebElement
7373
await searchBar.sendKeys('Webdriver');

‎docs_source_files/content/webdriver/web_element.ja.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,10 @@ driver = new Builder().forBrowser('chrome').build();
6363
await driver.get('http://www.google.com');
6464

6565
//Get and store DOM element '<form>'
66-
let searchForm = await driver.findElement(By.name('f'));
66+
let searchForm = driver.findElement(By.name('f'));
6767

6868
//Get search box element from webElement 'form'
69-
let searchBar = await searchForm.findElement(By.name('q'));
69+
let searchBar = searchForm.findElement(By.name('q'));
7070

7171
//Perform action using WebElement
7272
await searchBar.sendKeys('Webdriver');

‎docs_source_files/content/webdriver/web_element.ko.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,10 @@ driver = new Builder().forBrowser('chrome').build();
6464
await driver.get('http://www.google.com');
6565

6666
//Get and store DOM element '<form>'
67-
let searchForm = await driver.findElement(By.name('f'));
67+
let searchForm = driver.findElement(By.name('f'));
6868

6969
//Get search box element from webElement 'form'
70-
let searchBar = await searchForm.findElement(By.name('q'));
70+
let searchBar = searchForm.findElement(By.name('q'));
7171

7272
//Perform action using WebElement
7373
await searchBar.sendKeys('Webdriver');

‎docs_source_files/content/webdriver/web_element.nl.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,10 @@ driver = new Builder().forBrowser('chrome').build();
6464
await driver.get('http://www.google.com');
6565

6666
//Get and store DOM element '<form>'
67-
let searchForm = await driver.findElement(By.name('f'));
67+
let searchForm = driver.findElement(By.name('f'));
6868

6969
//Get search box element from webElement 'form'
70-
let searchBar = await searchForm.findElement(By.name('q'));
70+
let searchBar = searchForm.findElement(By.name('q'));
7171

7272
//Perform action using WebElement
7373
await searchBar.sendKeys('Webdriver');

‎docs_source_files/content/webdriver/web_element.zh-cn.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,10 @@ driver = new Builder().forBrowser('chrome').build();
6363
await driver.get('http://www.google.com');
6464

6565
//Get and store DOM element '<form>'
66-
let searchForm = await driver.findElement(By.name('f'));
66+
let searchForm = driver.findElement(By.name('f'));
6767

6868
//Get search box element from webElement 'form'
69-
let searchBar = await searchForm.findElement(By.name('q'));
69+
let searchBar = searchForm.findElement(By.name('q'));
7070

7171
//Perform action using WebElement
7272
await searchBar.sendKeys('Webdriver');

0 commit comments

Comments
 (0)