Skip to content

Commit d5c089e

Browse files
authored
Merge pull request xerial#194 from odaira/clean-up-build-process
Use config.h and snappy-stubs-public.h generated by cmake
2 parents ba38102 + 23cca45 commit d5c089e

File tree

3 files changed

+15
-25
lines changed

3 files changed

+15
-25
lines changed

Makefile

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -104,11 +104,6 @@ $(SRC)/org/xerial/snappy/BitShuffleNative.h: $(TARGET)/jni-classes/org/xerial/sn
104104

105105
$(SNAPPY_SRC): $(SNAPPY_GIT_UNPACKED)
106106

107-
# Need to use cmake generated header stub for Windows
108-
ifeq ($(OS_NAME),Windows)
109-
SNAPPY_CXX_OPTS:=-include$(SNAPPY_OUT)/snappy-stubs-public.h
110-
endif
111-
112107
# aarch64 can use big-endian optimzied code
113108
ifeq ($(OS_ARCH),aarch64)
114109
SNAPPY_CXX_OPTS:=-DSNAPPY_IS_BIG_ENDIAN

Makefile.common

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,9 @@ Linux-x86_64_SNAPPY_FLAGS :=
9797
Linux-ppc_CXX := g++
9898
Linux-ppc_STRIP := strip
9999
ifeq ($(IBM_JDK_7),)
100-
Linux-ppc_CXXFLAGS := -DHAVE_CONFIG_H -Ilib/inc_linux -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m32
100+
Linux-ppc_CXXFLAGS := -Ilib/inc_linux -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m32
101101
else
102-
Linux-ppc_CXXFLAGS := -DHAVE_CONFIG_H -include lib/inc_linux/jni_md.h -include $(IBM_JDK_LIB)/jniport.h -I$(JAVA_HOME)/include -I$(JAVA_HOME)/include/linux -O2 -fPIC -m32
102+
Linux-ppc_CXXFLAGS := -include lib/inc_linux/jni_md.h -include $(IBM_JDK_LIB)/jniport.h -I$(JAVA_HOME)/include -I$(JAVA_HOME)/include/linux -O2 -fPIC -m32
103103
endif
104104
Linux-ppc_LINKFLAGS := -shared -static-libgcc -static-libstdc++
105105
Linux-ppc_LIBNAME := libsnappyjava.so
@@ -108,9 +108,9 @@ Linux-ppc_SNAPPY_FLAGS :=
108108
Linux-ppc64le_CXX := $(CROSS_PREFIX)g++
109109
Linux-ppc64le_STRIP := $(CROSS_PREFIX)strip
110110
ifeq ($(IBM_JDK_7),)
111-
Linux-ppc64le_CXXFLAGS := -DHAVE_CONFIG_H -Ilib/inc_linux -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m64
111+
Linux-ppc64le_CXXFLAGS := -Ilib/inc_linux -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m64
112112
else
113-
Linux-ppc64le_CXXFLAGS := -DHAVE_CONFIG_H -include $(IBM_JDK_LIB)/jni_md.h -include $(IBM_JDK_LIB)/jniport.h -I$(JAVA_HOME)/include -I$(JAVA_HOME)/include/linux -O2 -fPIC -m64
113+
Linux-ppc64le_CXXFLAGS := -include $(IBM_JDK_LIB)/jni_md.h -include $(IBM_JDK_LIB)/jniport.h -I$(JAVA_HOME)/include -I$(JAVA_HOME)/include/linux -O2 -fPIC -m64
114114
endif
115115
Linux-ppc64le_LINKFLAGS := -shared -static-libgcc -static-libstdc++
116116
Linux-ppc64le_LIBNAME := libsnappyjava.so
@@ -119,9 +119,9 @@ Linux-ppc64le_SNAPPY_FLAGS :=
119119
Linux-ppc64_CXX := $(CROSS_PREFIX)g++
120120
Linux-ppc64_STRIP := $(CROSS_PREFIX)strip
121121
ifeq ($(IBM_JDK_7),)
122-
Linux-ppc64_CXXFLAGS := -DHAVE_CONFIG_H -Ilib/inc_linux -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m64
122+
Linux-ppc64_CXXFLAGS := -Ilib/inc_linux -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m64
123123
else
124-
Linux-ppc64_CXXFLAGS := -DHAVE_CONFIG_H -include $(IBM_JDK_LIB)/jni_md.h -include $(IBM_JDK_LIB)/jniport.h -I$(JAVA_HOME)/include -I$(JAVA_HOME)/include/linux -O2 -fPIC -m64
124+
Linux-ppc64_CXXFLAGS := -include $(IBM_JDK_LIB)/jni_md.h -include $(IBM_JDK_LIB)/jniport.h -I$(JAVA_HOME)/include -I$(JAVA_HOME)/include/linux -O2 -fPIC -m64
125125
endif
126126
Linux-ppc64_LINKFLAGS := -shared -static-libgcc -static-libstdc++
127127
Linux-ppc64_LIBNAME := libsnappyjava.so
@@ -131,9 +131,9 @@ AIX-ppc_CXX := g++
131131
AIX-ppc_STRIP := strip
132132
AIX-ppc_LIBNAME := libsnappyjava.a
133133
ifeq ($(IBM_JDK_7),)
134-
AIX-ppc_CXXFLAGS := -DHAVE_CONFIG_H -Ilib/inc_linux -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -maix32
134+
AIX-ppc_CXXFLAGS := -Ilib/inc_linux -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -maix32
135135
else
136-
AIX-ppc_CXXFLAGS := -DHAVE_CONFIG_H -I$(JAVA_HOME)/include/aix -Ilib/inc_ibm -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -maix32
136+
AIX-ppc_CXXFLAGS := -I$(JAVA_HOME)/include/aix -Ilib/inc_ibm -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -maix32
137137
endif
138138
AIX-ppc_LINKFLAGS := -shared -static-libgcc -static-libstdc++ -lcrypt
139139
AIX-ppc_SNAPPY_FLAGS :=
@@ -142,19 +142,19 @@ AIX-ppc64_CXX := g++
142142
AIX-ppc64_STRIP := strip -X64
143143
AIX-ppc64_LIBNAME := libsnappyjava.a
144144
ifeq ($(IBM_JDK_7),)
145-
AIX-ppc64_CXXFLAGS := -DHAVE_CONFIG_H -Ilib/inc_linux -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -maix64
145+
AIX-ppc64_CXXFLAGS := -Ilib/inc_linux -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -maix64
146146
else
147-
AIX-ppc64_CXXFLAGS := -DHAVE_CONFIG_H -I$(JAVA_HOME)/include/aix -Ilib/inc_ibm -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -maix64
147+
AIX-ppc64_CXXFLAGS := -I$(JAVA_HOME)/include/aix -Ilib/inc_ibm -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -maix64
148148
endif
149149
AIX-ppc64_LINKFLAGS := -shared -static-libgcc -static-libstdc++ -lcrypt
150150
AIX-ppc64_SNAPPY_FLAGS :=
151151

152152
Linux-s390_CXX := g++
153153
Linux-s390_STRIP := strip
154154
ifeq ($(IBM_JDK_7),)
155-
Linux-s390_CXXFLAGS := -DHAVE_CONFIG_H -Ilib/inc_linux -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m31
155+
Linux-s390_CXXFLAGS := -Ilib/inc_linux -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m31
156156
else
157-
Linux-s390_CXXFLAGS := -DHAVE_CONFIG_H -I$(JAVA_HOME)/include/linux -Ilib/inc_ibm -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -m31
157+
Linux-s390_CXXFLAGS := -I$(JAVA_HOME)/include/linux -Ilib/inc_ibm -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -m31
158158
endif
159159
Linux-s390_LINKFLAGS := -shared -static-libgcc -static-libstdc++
160160
Linux-s390_LIBNAME := libsnappyjava.so
@@ -163,9 +163,9 @@ Linux-s390_SNAPPY_FLAGS :=
163163
Linux-s390x_CXX := g++
164164
Linux-s390x_STRIP := strip
165165
ifeq ($(IBM_JDK_7),)
166-
Linux-s390x_CXXFLAGS := -DHAVE_CONFIG_H -Ilib/inc_linux -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m64
166+
Linux-s390x_CXXFLAGS := -Ilib/inc_linux -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -fvisibility=hidden -m64
167167
else
168-
Linux-s390x_CXXFLAGS := -DHAVE_CONFIG_H -I$(JAVA_HOME)/include/linux -Ilib/inc_ibm -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -m64
168+
Linux-s390x_CXXFLAGS := -I$(JAVA_HOME)/include/linux -Ilib/inc_ibm -I$(JAVA_HOME)/include -Ilib/inc_mac -O2 -fPIC -m64
169169
endif
170170
Linux-s390x_LINKFLAGS := -shared -static-libgcc -static-libstdc++
171171
Linux-s390x_LIBNAME := libsnappyjava.so
@@ -277,7 +277,7 @@ SNAPPY_FLAGS := $($(os_arch)_SNAPPY_FLAGS)
277277

278278

279279

280-
CXXFLAGS := $(CXXFLAGS) -Ilib/include
280+
CXXFLAGS := $(CXXFLAGS) -DHAVE_CONFIG_H
281281
ifneq ($(jni_include),)
282282
CXXFLAGS := $(CXXFLAGS) -I"$(jni_include)"
283283
endif

lib/include/config.h

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)