defer updating from web until after thread starts

Author: chetan

src/main/java/cz/mallat/uasparser/OnlineUpdater.java

@@ -79,7 +79,7 @@ public OnlineUpdater(UASparser parser, String cacheDir, long interval, TimeUnit
     }
 
     /**
-     * Initialize the parser and start update thread
+     * Initialize the parser with cached data. Falls back to vendored copy if no cache is available.
      */
     public void init() {
 
@@ -94,13 +94,10 @@ public void init() {
             }
         }
 
-        // try online update
-        if (!update()) {
-            try {
-                // fallback to vendored copy
-                parser.loadDataFromFile(getVendoredInputStream());
-            } catch (IOException e) {
-            }
+        try {
+            // fall back to vendored copy so we don't block on startup
+            parser.loadDataFromFile(getVendoredInputStream());
+        } catch (IOException e) {
         }
     }
 
@@ -142,12 +139,12 @@ public boolean update() {
     @Override
     public void run() {
         while (true) {
+            update();
             try {
                 Thread.sleep(updateInterval);
             } catch (InterruptedException e) {
                 return;
             }
-            update();
         }
     }