refactors paths

Author: tonylifu

README.md

@@ -1,7 +1,10 @@
 # WSMS
 
-### Reference Documentation 
+## Reference Documentation 
 
 * Student Record Manager
 * User Record Manager
-* Authentication and Authorisation
+* Authentication and Authorisation
+
+### Student Record Manager
+Creates and maintains student records

src/main/java/com/lifu/wsms/reload/controller/user/UserController.java

@@ -14,12 +14,15 @@ public class UserController {
 
     public static final String USER_PATH = "/api/v1/users";
     public static final String USER_PATH_USERNAME = USER_PATH + "/{username}";
-    public static final String USER_PATH_SET_PASSWORD = USER_PATH_USERNAME + "/set-password";
-    public static final String USER_PATH_CHANGE_PASSWORD = USER_PATH_USERNAME + "/change-password";
-    public static final String USER_PATH_CHANGE_STATUS = USER_PATH_USERNAME + "/change-status";
+    public static final String SET_PASSWORD_PATH = "/set-password";
+    public static final String USER_PATH_SET_PASSWORD = USER_PATH_USERNAME + SET_PASSWORD_PATH;
+    public static final String CHANGE_PASSWORD_PATH = "/change-password";
+    public static final String USER_PATH_CHANGE_PASSWORD = USER_PATH_USERNAME + CHANGE_PASSWORD_PATH;
+    public static final String CHANGE_STATUS_PATH = "/change-status";
+    public static final String USER_PATH_CHANGE_STATUS = USER_PATH_USERNAME + CHANGE_STATUS_PATH;
     public static final String ADD_ROLES_PATH = "/add-roles";
     public static final String USER_PATH_ADD_ROLES = USER_PATH_USERNAME + ADD_ROLES_PATH;
-    private static final String LOCATION = "location";
+    public static final String LOCATION = "location";
 
     @PostMapping(USER_PATH)
     public ResponseEntity<?> createUser(@RequestBody final CreateUserRequest createUserRequest) {

src/test/java/com/lifu/wsms/reload/controller/user/UserControllerTest.java

@@ -19,8 +19,7 @@
 import java.util.HashSet;
 import java.util.Set;
 
-import static com.lifu.wsms.reload.controller.user.UserController.ADD_ROLES_PATH;
-import static com.lifu.wsms.reload.controller.user.UserController.USER_PATH;
+import static com.lifu.wsms.reload.controller.user.UserController.*;
 import static com.lifu.wsms.reload.util.UserTestUtil.getCreateUserDTO;
 import static com.lifu.wsms.reload.util.UserTestUtil.getUpdateUserDTO;
 import static org.junit.jupiter.api.Assertions.*;
@@ -46,7 +45,7 @@ void shouldCreateAndReadUser() {
         assertEquals(HttpStatus.CREATED, createUserResponseEntity.getStatusCode());
 
         //When
-        String location = createUserResponseEntity.getHeaders().getFirst("location");
+        String location = createUserResponseEntity.getHeaders().getFirst(LOCATION);
         ResponseEntity<String> getUserResponseEntity = restTemplate.getForEntity(location, String.class);
 
         //Then
@@ -96,7 +95,7 @@ void shouldCreateAndReadUser() {
         assertFalse(isPasswordSet);
 
         //When
-        restTemplate.put(location + "/set-password", passwordSetRequest);
+        restTemplate.put(location + SET_PASSWORD_PATH, passwordSetRequest);
         ResponseEntity<String> getUserResponseEntityAfterPasswordSet = restTemplate.getForEntity(location, String.class);
 
         //Then
@@ -114,7 +113,7 @@ void shouldCreateAndReadUser() {
         changePasswordRequest.setNewPassword(newPassword);
 
         //Then
-        restTemplate.put(location + "/change-password", changePasswordRequest);
+        restTemplate.put(location + CHANGE_PASSWORD_PATH, changePasswordRequest);
         ResponseEntity<String> getUserResponseEntityAfterPasswordChange = restTemplate.getForEntity(location, String.class);
 
         DocumentContext documentContextAfterPasswordChange = JsonPath.parse(getUserResponseEntityAfterPasswordChange.getBody());
@@ -130,7 +129,7 @@ void shouldCreateAndReadUser() {
         //When
         UserStatusUpdateRequest statusUpdateRequest = new UserStatusUpdateRequest();
         statusUpdateRequest.setStatus(UserStatus.ACTIVE);
-        restTemplate.put(location + "/change-status", statusUpdateRequest);
+        restTemplate.put(location + CHANGE_STATUS_PATH, statusUpdateRequest);
         ResponseEntity<String> getUserResponseEntityAfterStatusUpdate = restTemplate.getForEntity(location, String.class);
 
         //Then