NH-802 - Fix build warnings

Author: hazzik

src/NHibernate/Bytecode/Lightweight/ReflectionOptimizer.cs

@@ -100,7 +100,9 @@ protected virtual void ThrowExceptionForNoDefaultCtor(System.Type type)
 		protected DynamicMethod CreateDynamicMethod(System.Type returnType, System.Type[] argumentTypes)
 		{
 			System.Type owner = mappedType.IsInterface ? typeof (object) : mappedType;
+#pragma warning disable 618
 			bool canSkipChecks = SecurityManager.IsGranted(new ReflectionPermission(ReflectionPermissionFlag.MemberAccess));
+#pragma warning restore 618
 			return new DynamicMethod(string.Empty, returnType, argumentTypes, owner, canSkipChecks);
 		}
 
@@ -244,4 +246,4 @@ private SetPropertyValuesInvoker GenerateSetPropertyValuesMethod(IGetter[] gette
 			return (SetPropertyValuesInvoker) method.CreateDelegate(typeof (SetPropertyValuesInvoker));
 		}
 	}
-}
+}

src/NHibernate/Dialect/BitwiseNativeOperation.cs

@@ -10,7 +10,6 @@ namespace NHibernate.Dialect
 	/// <summary>
 	/// Treats bitwise operations as native operations.
 	/// </summary>
-	/// </remarks>
 	[Serializable]
 	public class BitwiseNativeOperation : ISQLFunction
 	{

src/NHibernate/Hql/Ast/ANTLR/Generated/SqlGenerator.cs

@@ -34,7 +34,7 @@ namespace  NHibernate.Hql.Ast.ANTLR
 /**
  * SQL Generator Tree Parser, providing SQL rendering of SQL ASTs produced by the previous phase, HqlSqlWalker.  All
  * syntax decoration such as extra spaces, lack of spaces, extra parens, etc. should be added by this class.
- * <br>
+ * <br/>
  * This grammar processes the HQL/SQL AST and produces an SQL string.  The intent is to move dialect-specific
  * code into a sub-class that will override some of the methods, just like the other two grammars in this system.
  * @author Joshua Davis ([email protected])

src/NHibernate/Hql/Ast/ANTLR/HqlToken.cs

@@ -44,22 +44,6 @@ public bool PossibleId
             get { return HqlParser.possibleIds[Type]; }
         }
 
-        /// <summary>
-        /// Gets or Sets the type of the token, remembering the previous type on Sets.
-        /// </summary>
-        //public override int Type
-        //{
-        //    get
-        //    {
-        //        return base.Type;
-        //    }
-        //    set
-        //    {
-        //        _previousTokenType = Type;
-        //        base.Type = value;
-        //    }
-        //}
-
         /// <summary>
         /// Returns the previous token type.
         /// </summary>
@@ -81,4 +65,4 @@ public override string ToString()
                     + CharPositionInLine + ",possibleID=" + PossibleId + "]";
         }
     }
-}
+}

src/NHibernate/Hql/Ast/ANTLR/SqlGenerator.g

@@ -1,7 +1,7 @@
 /**
  * SQL Generator Tree Parser, providing SQL rendering of SQL ASTs produced by the previous phase, HqlSqlWalker.  All
  * syntax decoration such as extra spaces, lack of spaces, extra parens, etc. should be added by this class.
- * <br>
+ * <br/>
  * This grammar processes the HQL/SQL AST and produces an SQL string.  The intent is to move dialect-specific
  * code into a sub-class that will override some of the methods, just like the other two grammars in this system.
  * @author Joshua Davis ([email protected])

src/NHibernate/Hql/Ast/ANTLR/Tree/ComponentJoin.cs

@@ -7,6 +7,7 @@
 
 namespace NHibernate.Hql.Ast.ANTLR.Tree
 {
+	[CLSCompliant(false)]
 	public class ComponentJoin : FromElement
 	{
 		private readonly string columns;
@@ -172,4 +173,4 @@ private string GetPropertyPath(string propertyName)
 
 		#endregion
 	}
-}
+}

src/NHibernate/Hql/Ast/ANTLR/Tree/DotNode.cs

@@ -41,7 +41,9 @@ public class DotNode : FromReferenceNode
 		/// <summary>
 		/// The type of dereference that happened (DEREF_xxx).
 		/// </summary>
+#pragma warning disable 414
 		private int _dereferenceType = DerefUnknown;
+#pragma warning restore 414
 
 		/// <summary>
 		/// The identifier that is the name of the property.

src/NHibernate/Hql/Ast/ANTLR/Tree/FromClause.cs

@@ -23,7 +23,9 @@ public class FromClause : HqlSqlWalkerNode, IDisplayableNode
 		/// <summary>
 		/// Counts the from elements as they are added.
 		/// </summary>
+#pragma warning disable 649
 		private int _fromElementCounter;
+#pragma warning restore 649
 
 		private readonly NullableDictionary<string, FromElement> _fromElementByClassAlias = new NullableDictionary<string, FromElement>();
 		private readonly Dictionary<string, FromElement> _fromElementByTableAlias = new Dictionary<string, FromElement>();

src/NHibernate/Hql/Ast/ANTLR/Tree/ResultVariableRefNode.cs

@@ -16,6 +16,7 @@ namespace NHibernate.Hql.Ast.ANTLR.Tree
 	/// "value" used in the order by clause is a reference to the result_variable, "value", defined in the select clause.
 	/// </example>
 	/// Author: Gail Badner
+	[CLSCompliant(false)]
 	public class ResultVariableRefNode : HqlSqlWalkerNode
 	{
 		private ISelectExpression _selectExpression;

src/NHibernate/Id/Enhanced/TableGenerator.cs

@@ -239,11 +239,11 @@ public virtual void Configure(IType type, IDictionary<string, string> parms, Dia
 
 		#endregion
 
-
 		/// <summary>
 		///  Determine the table name to use for the generator values. Called during configuration.
 		/// </summary>
 		/// <param name="parms">The parameters supplied in the generator config (plus some standard useful extras).</param>
+		/// <param name="dialect">The dialect</param>
 		protected string DetermineGeneratorTableName(IDictionary<string, string> parms, Dialect.Dialect dialect)
 		{
 			string name = PropertiesHelper.GetString(TableParam, parms, DefaultTable);
@@ -277,6 +277,7 @@ protected string DetermineGeneratorTableName(IDictionary<string, string> parms,
 		/// Called during configuration.
 		/// </summary>
 		/// <param name="parms">The parameters supplied in the generator config (plus some standard useful extras).</param>
+		/// <param name="dialect">The <see cref="Dialect.Dialect"/></param>
 		protected string DetermineSegmentColumnName(IDictionary<string, string> parms, Dialect.Dialect dialect)
 		{
 			// NHibernate doesn't seem to have anything resembling this ObjectNameNormalizer. Ignore that for now.

src/NHibernate/Impl/ExpressionProcessor.cs

@@ -174,13 +174,15 @@ static ExpressionProcessor()
 		    RegisterCustomProjection(() => default(DateTimeOffset).Second, e => ProjectionsExtensions.ProcessSecond(e.Expression));
 		    RegisterCustomProjection(() => default(DateTimeOffset).Date, e => ProjectionsExtensions.ProcessDate(e.Expression));
 
+#pragma warning disable 618
 			RegisterCustomProjection(() => ProjectionsExtensions.YearPart(default(DateTime)), e => ProjectionsExtensions.ProcessYear(e.Arguments[0]));
 			RegisterCustomProjection(() => ProjectionsExtensions.DayPart(default(DateTime)), e => ProjectionsExtensions.ProcessDay(e.Arguments[0]));
 			RegisterCustomProjection(() => ProjectionsExtensions.MonthPart(default(DateTime)), e => ProjectionsExtensions.ProcessMonth(e.Arguments[0]));
 			RegisterCustomProjection(() => ProjectionsExtensions.HourPart(default(DateTime)), e => ProjectionsExtensions.ProcessHour(e.Arguments[0]));
 			RegisterCustomProjection(() => ProjectionsExtensions.MinutePart(default(DateTime)), e => ProjectionsExtensions.ProcessMinute(e.Arguments[0]));
 			RegisterCustomProjection(() => ProjectionsExtensions.SecondPart(default(DateTime)), e => ProjectionsExtensions.ProcessSecond(e.Arguments[0]));
 			RegisterCustomProjection(() => ProjectionsExtensions.DatePart(default(DateTime)), e => ProjectionsExtensions.ProcessDate(e.Arguments[0]));
+#pragma warning restore 618
 
             RegisterCustomProjection(() => ProjectionsExtensions.Sqrt(default(int)), ProjectionsExtensions.ProcessSqrt);
 			RegisterCustomProjection(() => ProjectionsExtensions.Sqrt(default(double)), ProjectionsExtensions.ProcessSqrt);

src/NHibernate/Impl/SessionImpl.cs

@@ -205,6 +205,7 @@ void IDeserializationCallback.OnDeserialization(object sender)
 		/// <param name="autoCloseSessionEnabled">Should we auto close after completion of transaction</param>
 		/// <param name="ignoreExceptionBeforeTransactionCompletion">Should we ignore exceptions in IInterceptor.BeforeTransactionCompletion</param>
 		/// <param name="connectionReleaseMode">The mode by which we should release JDBC connections.</param>
+		/// <param name="defaultFlushMode">The default flush mode for this session</param>
 		internal SessionImpl(
 			IDbConnection connection,
 			SessionFactoryImpl factory,

src/NHibernate/Linq/Visitors/WhereJoinDetector.cs

@@ -31,7 +31,7 @@ namespace NHibernate.Linq.Visitors
 	/// For example:
 	/// a.B.C == 1 could never produce true if B didn't match any rows, so it's safe to inner join.
 	/// a.B.C == null could produce true even if B didn't match any rows, so we can't inner join.
-	/// a.B.C == 1 && a.D.E == 1 can be inner joined.
+	/// a.B.C == 1 && a.D.E == 1 can be inner joined.
 	/// a.B.C == 1 || a.D.E == 1 must be outer joined.
 	/// 
 	/// By default we outer join via the code in VisitExpression.  The use of inner joins is only