NH-3842 - Fix DateTimeOffsetType throwing exception in DefaultValue property

Author: hazzik

src/NHibernate.Test/NHSpecificTest/Dates/DateTimeOffsetFixture.cs

@@ -1,6 +1,9 @@
 using System;
 using System.Collections;
 using System.Data;
+using System.IO;
+using System.Runtime.Serialization.Formatters.Binary;
+using System.Xml.Serialization;
 using NHibernate.Driver;
 using NHibernate.Type;
 using NUnit.Framework;
@@ -101,5 +104,32 @@ public void Seed()
 			Assert.That(type.Seed(null), Is.TypeOf<DateTimeOffset>());
 		}
 
+		[Test(Description = "NH-3842")]
+		public void DefaultValueDoesNotThrowException()
+		{
+			var type = NHibernateUtil.DateTimeOffset;
+
+			Assert.That(() => type.DefaultValue, Throws.Nothing);
+		}
+
+		[Test(Description = "NH-3842")]
+		public void CanBinarySerialize()
+		{
+			var type = NHibernateUtil.DateTimeOffset;
+
+			var formatter = new BinaryFormatter();
+
+			Assert.That(() => formatter.Serialize(Stream.Null, type), Throws.Nothing);
+		}
+
+		[Test(Description = "NH-3842")]
+		public void CanXmlSerialize()
+		{
+			var type = NHibernateUtil.DateTimeOffset;
+
+			var formatter = new XmlSerializer(typeof(DateTimeOffsetType));
+
+			Assert.That(() => formatter.Serialize(Stream.Null, type), Throws.Nothing);
+		}
 	}
-}
+}

src/NHibernate/Type/DateTimeOffSetType.cs

@@ -13,6 +13,8 @@ namespace NHibernate.Type
 	[Serializable]
 	public class DateTimeOffsetType : PrimitiveType, IIdentifierType, ILiteralType, IVersionType
 	{
+		static readonly DateTimeOffset BaseDateValue = DateTimeOffset.MinValue;
+
 		/// <summary></summary>
 		public DateTimeOffsetType()
 			: base(SqlTypeFactory.DateTimeOffSet)
@@ -36,7 +38,7 @@ public override System.Type PrimitiveClass
 
 		public override object DefaultValue
 		{
-			get { throw new NotImplementedException(); }
+			get { return BaseDateValue; }
 		}
 
 		public IComparer Comparator
@@ -56,7 +58,6 @@ public override object Get(IDataReader rs, int index)
 			try
 			{
 				var dbValue = (DateTimeOffset) rs[index];
-				;
 				return new DateTimeOffset(dbValue.Ticks, dbValue.Offset);
 			}
 			catch (Exception ex)
@@ -118,4 +119,4 @@ public override string ObjectToSQLString(object value, Dialect.Dialect dialect)
 			return "'" + ((DateTimeOffset) value) + "'";
 		}
 	}
-}
+}